Repository navigation
docs: answer the review's stale points in Often missed and the record-check text - #1341
Merged
Merged
Conversation
…, pixel scaling and undo in Often missed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An external review (built from older docs) said OpenAdapt's record check needs a hand-written API, SQL or FHIR verifier, that the pixel path halts on any display-scaling change, and that a mid-run stop leaves earlier changes behind. All three are now out of date on main:
scaffold-verifierbuilds it from the app's own read-back, found in captured network traffic or a read-only database, and tries to break it before review (feat(flow): build a working record check from the app's own reads #1284). Flow's README still said the draft "checks nothing until a person edits it"; that is now only the fallback when no read is found.undolists the changes made before the stop and reverses them with approved undo steps (feat(flow): change ledger, write-ordering lint and declared undo after a stop #1263).Also: the API-steps row said #1269 was "being merged"; it is on main.
🤖 Generated with Claude Code