[abrichr]

A popup can close itself from the click that finishes it, such as an approval or sign-in window. Playwright can report "Target page, context or browser has been closed" after it delivered that click. Before this change:

• the scripted recorder raised on it, which is the intermittent test_scripted_recorder_switches_back_from_a_self_closed_popup failure on flow: keep pixel-path replays running across display scaling and ClearType #1286;
• replay recorded the step's delivery as uncertain.

Now that report counts as a delivered click only when the step expects its popup to close. Every other "page closed" report stays uncertain.

Rule

PlaywrightBackend (click, act_structural, act_guarded_coordinate) treats a TargetClosedError as delivered only when all of these hold:

1. the step armed an expected close (expect_page_close(), one-shot);
2. the backend is a popup surface (closed_page_frame=True, a page a step opened, per feat: multi-tab, popup, and backend-switching surfaces (carry-over of openadapt-flow#533) #1197);
3. the page was open when the click started;
4. the page reads as closed within 1 s.

Otherwise it raises ActionDeliveryUncertain. Other errors are unchanged.

Where the expectation comes from

• Recorder: a click that leaves its popup surface closed is recorded as closes_surface: true. This covers driven and observed (interactive) recordings, and is checked after the settle wait because the close is asynchronous. While delivering a click on a popup, the recorder arms the expectation, so recording continues past the report.
• IR: new field Step.closes_surface. It is valid only on a click or double-click that runs on a page a step opened. A False value is omitted from the sealed v2 digest (same rule as opens and dialog), so existing bundles keep their digests.
• Replayer: _act arms the backend for a closes_surface step only, and cancels the expectation afterwards. The new seam is PageCloseExpectationBackend in backend.py.

Tests

• tests/test_page_close_delivery.py (13 tests):
  • backend: expected close counts as delivered; unexpected close stays uncertain; the primary page is never accepted; a page still open stays uncertain; a page already closed before the click stays uncertain; the expectation is one-shot; a cancelled expectation is ignored; other errors are passed through unchanged;
  • IR validation;
  • the replayer arms only for a closing step.
• tests/test_multi_surface_selfclose_delivery.py (2 tests, real Playwright on the fixture's self-closing sign-in popup): every popup click is forced to raise TargetClosedError after it is delivered.
  • Recording continues and marks the closing step.
  • The replay counts it as delivered and succeeds.
  • The same bundle with closes_surface cleared records delivery_uncertainty with cause TargetClosedError.
• tests/test_bundle_schema_v2.py: pre-field digests are preserved.
• Locally, the multi-surface, recorder, compile, Playwright backend and bundle suites pass. Ruff, format, the strict mypy subset and release consistency are clean.

This is a new file, so it doesn't conflict with #1283's changes to test_multi_surface_selfclose.py, which cover the test's direct popup.click.

🤖 Generated with Claude Code