Repository navigation
feat(agent): authoring pins the app a deployment file names - #1287
Merged
Merged
Conversation
openadapt-agent serve --authoring --config deploy.yaml now pins the app the file's backend: section names, through the same factory openadapt-flow run uses: a Windows app, one macOS or Linux window, or an RDP or Citrix client window. Linux had no pin at all, and macOS could pin only the frontmost window. Combining it with another pin flag, or a web section, is refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rk RDP Review fixes: - --authoring-from-config opts in. A --config given only for runs no longer pins authoring. - Network RDP (rdp_host) is refused for authoring: each run's own session would disconnect it. - A Windows section without agent_token takes OAFLOW_AGENT_TOKEN, as --windows-agent-url does; --remote-window-title counts as another pin. - An unreadable deployment file is reported as an authoring error, not a traceback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent authoring (
openadapt-agent serve --authoring) couldn't record a Linux app at all, and on macOS it could pin only the frontmost window. It can now pin whatever app a deployment file names.What changed
serve --authoring --config deploy.yaml --authoring-from-configpins the app named by the file'sbackend:section. This can be a Windows app, one macOS or Linux window, or an RDP or Citrix client window. It uses the samebuild_backendthatopenadapt-flow run --configuses, so the recording and its runs drive the same app.pin_local_backend(deployment_backend=...)andopen_authoring_session(deployment_backend=...)take the section directly.backend_hints, so replay binds the same client window.--url,--windows-agent-url,--remote-windowor--citrix("pin one target");kind: websection (use--url --headed).packages/agent/README.md: one paragraph.Tests
packages/agent/tests/test_authoring_native.py(factory faked, real FlowAuthoringSession):meta.json;--configpins.Result: 19 passed. Locally, 5 tests in
test_authoring.pyfail on main too, because of this machine'smcpversion; CI decides.Part of the backend parity work (#1282).
🤖 Generated with Claude Code
Review fixes (second commit)
--authoring-from-config. A--configgiven only for runs no longer pins authoring.rdp_host) is refused for authoring, because each run's own session would disconnect the recording's.agent_tokentakesOAFLOW_AGENT_TOKEN, as--windows-agent-urldoes.--remote-window-titlenow counts as another pin.linux_allow_physical_input: truefor agent clicks.