Repository navigation
StartMenu: Windows 11 Start button placement and responsive native drag-and-drop - #2566
projektion0 wants to merge 5 commits into
Conversation
Preserve native Shell async transfer negotiation, retain menus without stealing focus from transfer dialogs, and observe folder changes. Restore outside-click dismissal and keep the Shell drag preview visible above raised submenus.
|
Preserve native Shell asynchronous drop negotiation is implemented to have a bugfix for hanging copy dialog when moving folders via drag&drop in start menu and replacing files |
|
It would be great to not mix new features and fixes (of existing ones) in single PR. |
There was a problem hiding this comment.
I don't like adding another SLN file.
We can convert existing SLN to VS2026 (just explicitly save it once opened in VS2026).
That way it will be opened with VS2026 by default.
But it will still load in VS2022 (if VS2026 is not present).
We need to do official builds with VS2022 (due to Win7 support). But that will work fine even with SLN file saved by VS2026.
|
Please, add references to issues/discussions that given commit aims to fix. |
Dragging and moving files through the Start Menu can stall at the native "Replace files in the destination" dialog until Windows Start is opened. This change lets the native Shell negotiate asynchronous transfers and keeps the menu usable and up to date while the transfer runs.
This draft collects the related Windows 11 changes developed and tested together, with separate commits for build support, the Start button, drag-and-drop, and shortcut-location resolution.
Changes
BHID_LinkTargetItemon the worker STA, obtain its target PIDL, and fall back to the original PIDL for non-links or unresolved links. This commit is cherry-picked from YellowNest/aaa8c635, preserving the original author. The separate shortcut-folder command retains its behavior.Validation
9dfa7fa5c3614de15d0ff4f3eba7edd9e2dcbd24in a separate checkout; all 12 feature source files match the locally tested version..targetsimport locally; the import was recovered from the restored package archive before building.python tests/run_open_containing.py: 68 checks passed, using real Shell links, target binding and PIDL extraction. Only the final Explorer folder-selection call is intercepted. Covers Unicode/spaces/arguments, folder links, non-links, unresolved links, error propagation, STA execution and caller message pumping.git diff --checkpasses. Toolset property evaluation selects v143 for VS 2022 and v145 for VS 2026. VS 2022 compilation, x86/ARM64 builds and installer packaging have not been run for this draft.Built binaries, external language DLLs, the local deployment script and private machine paths are excluded. Release version numbering remains under the existing release scripts.