Repository navigation
fix(cli): name the ECMA-427 identity grammar in the usage text - #3
Merged
Merged
Conversation
The usage text still advertised pkg:<vcs>/<host>/<path>, which svn and hg identities now refuse; it and the lock's Resource comment name the pkg:generic form and the two input spellings. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syspi -hstill advertisedpkg:<vcs>/<host>/<path>[@<version>][#<subpath>], the pre-ECMA-427 grammar: since #2,pkg:svn/…andpkg:hg/…written that way are refused, so the help contradicted the tool. The usage text now shows the canonical form and the two input spellingsorigin.Spellingsalready names in error messages:The
lock.Entry.Resourcecomment carried the same stale grammar and is corrected. No behaviour change;changes/unreleased/help-identity-grammar.fixed.mdrecords it.