Repository navigation
refactor(runtime): clear the runtime SonarCloud code smells - #1818
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clears the three SonarCloud code smells on develop in
internal/exec/runtimethat are not owned by #1802:go:S1186context.go:1833— the no-opreleasereturned for a reused performance now says why it is empty: the performance stays its owner's to release. The sibling empty func atcontext.go:1917belongs to refactor(export): build a document's identity facts through per-symbol helpers #1802 and is untouched.godre:S8196statements.go:1748— the unexported single-method interfaceactionStepHostis renamedassignRecorderafter its methodrecordAssign; its only use is the type assertion in the same file, and no other package can see it.go:S117action_trace_records_test.go:55— the localgo_is renamedgoSignal; the test asserts exactly what it did before.Pure refactor, no behaviour change, so no changelog fragment.
How it was verified
go build ./...,go vet ./...,gofmt -l .(empty)go test -count=1 ./internal/exec/runtime/...— passanalyze_code_snippeton develop vs this branch:go:S1186@1833andgo:S117@55gone; only the refactor(export): build a document's identity facts through per-symbol helpers #1802-ownedS1186remains incontext.go.godre:S8196is not reported by the analyzer and was checked by inspection (grep -rn actionStepHostis empty).Checklist
make testandmake lintpass locally (touched package suites + build/vet/gofmt)Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/d6cd1346a2844bb0aa32b31cc438fc6b
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/d6cd1346a2844bb0aa32b31cc438fc6b?variant=devin
Requested by: @HuiJun