Repository navigation
fix(tag): show the waiting hint briefly instead of permanently - #492
Merged
Merged
Conversation
The waiting hint was refreshed every second for a lone player, so it covered the action bar for as long as tag was on. It is now sent once when the player becomes alone (switching tag on, joining, or the other player leaving). The tagger's action bar keeps its one-second refresh. Claude-Session: https://claude.ai/code/session_01T1vdbUkCCTsMRsnGsQJtGL
Contributor
Test results 832 files 832 suites 56m 2s ⏱️ Results for commit 4e5fe13. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lobby-tagspec is updated in a separatedocs(openspec)commit: the waiting hint is a brief notice, not a permanent bar.Root cause
TagModule.second()callsTagEffects.taggerChanged()every second, and that method refreshed the action bar of every active player, including the waiting text when there was no tagger.Tests
TagModuleIntegrationTest(Env,env.tick(), injected clock):./gradlew spotlessApply buildis green.Not changed
https://claude.ai/code/session_01T1vdbUkCCTsMRsnGsQJtGL