Skip to content

fix(tag): show the waiting hint briefly instead of permanently - #492

Merged
TheMeinerLP merged 2 commits into
mainfrom
fix/tag-waiting-actionbar
Oct 25, 2026
Merged

TheMeinerLP merged 2 commits into
mainfrom
fix/tag-waiting-actionbar

Conversation

@TheMeinerLP

Copy link
Copy Markdown
Contributor

Summary

  • The tag game's waiting hint ("Waiting for a second player ...") was refreshed every second for a lone player, so it covered the action bar for as long as tag was on.
  • The hint is now sent once, when a player becomes alone: switching tag on, joining a lobby with tag on, or the other player leaving the instance.
  • The tagger's action bar keeps its one-second refresh, so it does not fade while someone is "it".
  • The lobby-tag spec is updated in a separate docs(openspec) commit: the waiting hint is a brief notice, not a permanent bar.

Root cause

TagModule.second() calls TagEffects.taggerChanged() every second, and that method refreshed the action bar of every active player, including the waiting text when there was no tagger.

Tests

  • TagModuleIntegrationTest (Env, env.tick(), injected clock):
    • alone after switching tag on: one waiting hint, none after 100 ticks
    • joining alone with tag on: one waiting hint, none after 100 ticks
    • a second participant ends the waiting
    • the remaining player gets one waiting hint when the other player leaves
  • ./gradlew spotlessApply build is green.

Not changed

  • No start notice for the first two participants: the change does not define one, so the tagger's action bar is the feedback as before.

https://claude.ai/code/session_01T1vdbUkCCTsMRsnGsQJtGL

The waiting hint was refreshed every second for a lone player, so it
covered the action bar for as long as tag was on. It is now sent once
when the player becomes alone (switching tag on, joining, or the other
player leaving). The tagger's action bar keeps its one-second refresh.

Claude-Session: https://claude.ai/code/session_01T1vdbUkCCTsMRsnGsQJtGL
@TheMeinerLP
TheMeinerLP requested a review from a team as a code owner October 24, 2026 21:46
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Test results

  832 files    832 suites   56m 2s ⏱️
3 170 tests 3 169 ✅ 1 💤 0 ❌
6 366 runs  6 364 ✅ 2 💤 0 ❌

Results for commit 4e5fe13.

♻️ This comment has been updated with latest results.

@TheMeinerLP
TheMeinerLP merged commit 8a9f7d2 into main Oct 25, 2026
10 checks passed
@TheMeinerLP
TheMeinerLP deleted the fix/tag-waiting-actionbar branch October 25, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant