Repository navigation
feat(settings): make the settings menu friendlier with gradients and toggles - #491
Merged
Merged
Conversation
Contributor
Test results 442 files 442 suites 37m 3s ⏱️ Results for commit c54fd2f. ♻️ This comment has been updated with latest results. |
…toggles Each option gets a feature icon with an enchantment glint while it is on, and a lime or grey switch directly below it. The title, hotbar item and option names use the brand gradient, and all lore is non-italic. Clicking the icon or the switch flips the option and plays the UI button click. Claude-Session: https://claude.ai/code/session_01T1vdbUkCCTsMRsnGsQJtGL
TheMeinerLP
force-pushed
the
feat/settings-menu-polish
branch
from
October 25, 2026 08:51
8bb9e24 to
c54fd2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The settings menu looked unstyled next to the other lobby menus: plain white italic names, a bare title, and two dyes that only said "on" or "off" on hover. This PR makes it friendlier:
ui.button.clickfor the player.Gradient: the brand gradient
<gradient:#00ddff:#ffffff>used by the navigator's item and server picker. The texts stay in the MiniMessage bundles, as before.Layout (27 slots, 3 rows)
With the two current options the icons sit in slots 12 and 14 and the switches in 21 and 23.
SettingsLayoutspreads up to five options two columns apart and places six to nine on adjacent columns, always centred on column 4. More than nine options are rejected.Notes
openspec/changes/lobby-settings: the requirement that described "Lime bei an, Grau bei aus" now describes the icon and switch, in its own docs commit.hideExtraTooltip()is not set, because no other Titan menu uses it and these items carry no attribute components.Testing
SettingsMenuTest: icon and switch per option, glint only when on, name gradient and not italic, click on icon and on switch, click sound heard by the player.SettingsLayoutTest: column maths for 1, 2 and 9 options, and the rejection above nine.SettingsTextStyleTest: hotbar item and hint, title gradient, switch colours, description not italic.SettingsMessagesBundleTestcovers the new keytitan.settings.item.hintin both bundles../gradlew spotlessApply build --offlinepasses locally (PMD, ArchUnit, module boundaries included).https://claude.ai/code/session_01T1vdbUkCCTsMRsnGsQJtGL