Repository navigation
fix(command): require a permission for the start command - #405
Merged
Merged
Conversation
github-actions
Bot
added
the
area: game
Contributor
Test results 732 files 732 suites 6m 32s ⏱️ Results for commit 7e96aa0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/start(StartCommand) had no condition, so every player could force-start the lobby countdown.Fix
StartCommand now guards itself like StopCommand: players need the permission
cygnus.command.start, read from Adventure'sPermissionChecker.POINTER(backed by LuckPerms viaPermissionAwarePlayer, denied when the pointer is missing). Non-player senders such as the console stay allowed. The force-start logic is unchanged.Tests
New
StartCommandTest(4 tests, red before the fix, green after): player without permission denied, player withcygnus.command.startallowed, player with an unrelated permission denied, console allowed../gradlew :game:check --offline: BUILD SUCCESSFUL.https://claude.ai/code/session_01GbSVcSYDK6Tgt287Se2Gs9