Skip to content

Update to OneBusAway 2.7.2 - #143

Merged
aaronbrethorst merged 1 commit into
mainfrom
bump-2.7.2
Oct 13, 2026
Merged

aaronbrethorst merged 1 commit into
mainfrom
bump-2.7.2

Conversation

@aaronbrethorst

@aaronbrethorst aaronbrethorst commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Bumps OBA_VERSION from 2.7.1 to 2.7.2, which is now on Maven Central, in both images. Also updates the MBTA immutable example and CLAUDE.md.
  • Removes the server stage's duplicate ARG OBA_VERSION=… default in oba/Dockerfile. The global ARG already sets it, and the bare ARG OBA_VERSION later in that stage picks it up. Each bump now changes one line per Dockerfile.
  • Extends the CI check that compares pins across the two Dockerfiles so it fails when oba/ and bundler/ set different OBA_VERSION values. Before, it only compared the gtfstidy pin.

Test plan

  • Built bundler and oba images locally. The Maven logs show the 2.7.2 artifacts downloading from repo1, and the images contain the 2.7.2 jars with OBA_VERSION=2.7.2 in the environment.
  • Ran the CI "Services with Bundler" flow locally (docker-compose.yml + docker-compose.ci.yml, built a bundle from the GTFS fixture, brought the stack up). bin/validate.sh passed: current-time, agencies-with-coverage, routes-for-agency, stops-for-route, stop, stops-for-location and arrivals-and-departures-for-stop.
  • Ran the pin check script on its own: it passes on the current files, fails (exit 1) when the bundler pins 2.7.1, and fails when the pin is missing.
  • Rebuilt the oba image after removing the duplicate ARG: OBA_VERSION is still 2.7.2.

Review notes (not addressed here)

  • The notes in deployment-examples/multiple-rt-feeds/{docker-compose.yaml,README.md} say GTFS_RT_FEEDS "is not in a published release yet" and refer to 2.7.1-latest. Multi-feed support shipped in 2.7.1-v3.0.0, so those notes are out of date regardless of this bump.
  • Both Dockerfiles set ENV OBA_VERSION before the apt-get layers, so every OBA bump also rebuilds the apt/pip layers. Moving the ARG/ENV pair to just before the first RUN that uses it would keep those layers cached.

Summary by CodeRabbit

  • Updates
    • The OneBusAway API server and deployment examples now use version 2.7.2 instead of 2.7.1, providing the updated server version in new builds and deployments.
  • Maintenance
    • Build checks now verify that the OneBusAway and GTFS Tidy version pins match across the related images, helping catch inconsistent build configurations before they are used.

Also drops the server stage's duplicate OBA_VERSION default in
oba/Dockerfile (the global ARG already supplies it) and extends the CI
pin-drift guard to check OBA_VERSION matches across both images.
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3a34292a-47c3-4e4f-bd27-5ff220cb5def
📥 Commits

Reviewing files that changed from the base of the PR and between 40911cd and 1aea78d.

📒 Files selected for processing (5)
  • .github/workflows/test.yaml
  • CLAUDE.md
  • bundler/Dockerfile
  • deployment-examples/immutable/Dockerfile.mbta
  • oba/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The Docker build defaults and MBTA deployment image now use OBA 2.7.2. The workflow guard compares OBA and GTFS tidy version pins between the Dockerfiles.

Changes: OBA version update

Layer / File(s) Summary
Update OBA version declarations
oba/Dockerfile, bundler/Dockerfile, deployment-examples/immutable/Dockerfile.mbta, CLAUDE.md
The Docker build defaults, MBTA image tag, and documented version change to 2.7.2. The server stage keeps an OBA_VERSION argument without a stage-local default.
Check Dockerfile version pin parity
.github/workflows/test.yaml
The workflow compares OBA_VERSION and GTFSTIDY_VERSION argument lines between the Dockerfiles. Missing or different lines fail the step.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 1aea7

The OBA version is consistently updated to 2.7.2, and the workflow checks pin parity. No actionable merge-blocking issue was identified.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating OneBusAway to version 2.7.2.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aaronbrethorst
aaronbrethorst merged commit d6ce8a8 into main Oct 13, 2026
8 checks passed
@aaronbrethorst
aaronbrethorst deleted the bump-2.7.2 branch October 13, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant