Repository navigation
Update to OneBusAway 2.7.2 - #143
Conversation
Also drops the server stage's duplicate OBA_VERSION default in oba/Dockerfile (the global ARG already supplies it) and extends the CI pin-drift guard to check OBA_VERSION matches across both images.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Summary
OBA_VERSIONfrom 2.7.1 to 2.7.2, which is now on Maven Central, in both images. Also updates the MBTA immutable example and CLAUDE.md.ARG OBA_VERSION=…default inoba/Dockerfile. The global ARG already sets it, and the bareARG OBA_VERSIONlater in that stage picks it up. Each bump now changes one line per Dockerfile.oba/andbundler/set differentOBA_VERSIONvalues. Before, it only compared the gtfstidy pin.Test plan
bundlerandobaimages locally. The Maven logs show the 2.7.2 artifacts downloading from repo1, and the images contain the 2.7.2 jars withOBA_VERSION=2.7.2in the environment.docker-compose.yml+docker-compose.ci.yml, built a bundle from the GTFS fixture, brought the stack up).bin/validate.shpassed: current-time, agencies-with-coverage, routes-for-agency, stops-for-route, stop, stops-for-location and arrivals-and-departures-for-stop.obaimage after removing the duplicate ARG:OBA_VERSIONis still 2.7.2.Review notes (not addressed here)
deployment-examples/multiple-rt-feeds/{docker-compose.yaml,README.md}sayGTFS_RT_FEEDS"is not in a published release yet" and refer to2.7.1-latest. Multi-feed support shipped in 2.7.1-v3.0.0, so those notes are out of date regardless of this bump.ENV OBA_VERSIONbefore theapt-getlayers, so every OBA bump also rebuilds the apt/pip layers. Moving the ARG/ENV pair to just before the firstRUNthat uses it would keep those layers cached.Summary by CodeRabbit