Skip to content

app: warn on proposer config builder mismatch - #4784

Merged
KaloyanTanev merged 3 commits into
gloasfrom
kalo/proposer-config-builder-refresh
Oct 19, 2026
Merged

KaloyanTanev merged 3 commits into
gloasfrom
kalo/proposer-config-builder-refresh

Conversation

@KaloyanTanev

@KaloyanTanev KaloyanTanev commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Checks the builder settings of an existing vc-config/proposer-config.json on start against the builder flags, and warns on a mismatch. The flags only seed a new file; changing the builders of an existing one requires charon proposer-config edit, run in sync with the other peers. The file itself is never modified.

category: feature
ticket: #4324

@KaloyanTanev KaloyanTanev self-assigned this Oct 18, 2026
@github-actions github-actions Bot added the branch-invalid PR raised against invalid branch. Not a main or release branch. label Oct 18, 2026
@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (gloas@282a123). Learn more about missing BASE report.

Files with missing lines Patch % Lines
app/proposerconfig.go 69.69% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             gloas    #4784   +/-   ##
========================================
  Coverage         ?   67.23%           
========================================
  Files            ?      252           
  Lines            ?    33030           
  Branches         ?        0           
========================================
  Hits             ?    22209           
  Misses           ?    10820           
  Partials         ?        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev
KaloyanTanev force-pushed the kalo/proposer-config-builder-refresh branch from 3af4d99 to a8806cd Compare October 19, 2026 08:56
@KaloyanTanev KaloyanTanev changed the title app: update builder settings of proposer config on start app: warn on proposer config builder mismatch Oct 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@OisinKyne OisinKyne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't actually have to be fixed before merge, just logging it.

One thing to fix before merge: the warning tells operators to run charon proposerconfig edit, but that command doesn't exist. The PR description also spells it differently (proposer-config edit). Until the command lands, operators who see the warning have nothing they can do. The fix that works today is to delete the file and restart, which regenerates it from the current flags and overrides. Suggested wording:

▎ Builder flags differ from the proposer config file, which is only generated when missing. Delete it and restart to regenerate it, in sync with the other peers.

@KaloyanTanev
KaloyanTanev merged commit 7b382bd into gloas Oct 19, 2026
9 checks passed
@KaloyanTanev
KaloyanTanev deleted the kalo/proposer-config-builder-refresh branch October 19, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch-invalid PR raised against invalid branch. Not a main or release branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants