Repository navigation
app: warn on proposer config builder mismatch - #4784
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gloas #4784 +/- ##
========================================
Coverage ? 67.23%
========================================
Files ? 252
Lines ? 33030
Branches ? 0
========================================
Hits ? 22209
Misses ? 10820
Partials ? 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3af4d99 to
a8806cd
Compare
|
OisinKyne
left a comment
There was a problem hiding this comment.
Doesn't actually have to be fixed before merge, just logging it.
One thing to fix before merge: the warning tells operators to run charon proposerconfig edit, but that command doesn't exist. The PR description also spells it differently (proposer-config edit). Until the command lands, operators who see the warning have nothing they can do. The fix that works today is to delete the file and restart, which regenerates it from the current flags and overrides. Suggested wording:
▎ Builder flags differ from the proposer config file, which is only generated when missing. Delete it and restart to regenerate it, in sync with the other peers.



Checks the builder settings of an existing
vc-config/proposer-config.jsonon start against the builder flags, and warns on a mismatch. The flags only seed a new file; changing the builders of an existing one requirescharon proposer-config edit, run in sync with the other peers. The file itself is never modified.category: feature
ticket: #4324