Repository navigation
core: aggregate builder request auths for gloas builders - #4783
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gloas #4783 +/- ##
========================================
Coverage ? 67.46%
========================================
Files ? 253
Lines ? 33434
Branches ? 0
========================================
Hits ? 22556
Misses ? 10877
Partials ? 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e248db1 to
7ff561c
Compare
1b5689b to
152589f
Compare
|
OisinKyne
left a comment
There was a problem hiding this comment.
Fixed:
- False "inconsistent partial signed data" reports: builder preferences are now skipped in reportParSigs.
- Inline auth errors: an error forwarding the optional inline auths now logs a warning instead of failing the whole proposal.
- Shared hostnames: every configured builder on the same host now gets its preferences submitted.
- Metric label: the VC-supplied host is capped at 253 bytes and made valid UTF-8. This also fixes a possible crash I'd missed, since the Prometheus client panics on invalid UTF-8 labels.
Still open, none blocking an rc:
- The 500ms wait per proposal when a builder has no aggregate (fetcher.go:687) is unchanged. It's safe for rc1 because --builder-urls has no default and CDVN doesn't set it, so it only affects operators who opt in. It should still get the "skip if there's no partial" fix plus a metric for builders dropped from proposals before this goes default-on.
- Metric cardinality: the label is now capped in length, but a misbehaving VC can still create a new series per distinct host it signs. Collapsing unknown hosts to "unknown" (as the tracker does) is the real fix.
- Ordering: inline auths are still forwarded after randao, so they can arrive after the 500ms wait has started.
- Spec check: the DOMAIN_BUILDER_REQUEST_AUTH value still needs checking against the pinned builder-specs commit. Worth a quick look before rc1, because the testnet is the first place a wrong value would show up.
- Lower priority:
- The mismatch counter counts per submission rather than per proposal.
- The core_bcast_delay_seconds delay metric is off for this duty.
- The tracker can't see when one builder failed while another succeeded.
Bumps charon to `6e59dc0`, the latest `gloas` branch commit, which includes serving execution payload envelopes (ObolNetwork/charon#4765), agreeing on self-built blocks without payload (ObolNetwork/charon#4771) and aggregated builder request auths (ObolNetwork/charon#4783). Also bumps the clients to their Hoodi Glamsterdam ready releases: Lighthouse `v8.3.0`, Teku `26.10.1`, Lodestar `v1.50.0`, Prysm `v7.3.0`, Nimbus `v26.10.1`, Grandine `3.0.0-rc.1`, Nethermind `2.2.0` and Commit-Boost `v0.12.0-rc1`. Grandine and Commit-Boost are release candidates, but they are the versions listed for the Hoodi fork. Supersedes #492 and #493. The `obolnetwork/charon:6e59dc0` image is still building, so this should merge once it is published.



Adds the gloas builder preferences duty (#4724). Partial
SignedBuilderRequestAuths from validator clients, received ahead of time viaPOST /eth/v1/validator/builder_preferencesor inline in the v4 block production body, are threshold-aggregated per builder, attached to the proposal'sBuilderConfigand submitted to the beacon node. Bumps go-eth2-client tov0.30.1-obol.1-gloasand generalisesAggSigDB.Awaitto takeAwaitOpts.Stacked on #4771. The
Eth-Builder-Urlround-trip on publish is left for a follow-up.category: feature
ticket: #4324