Repository navigation
[IMP] webservice_server_env: do not auto install - #201
Merged
OCA-git-bot merged 1 commit intoNov 5, 2026
Merged
Conversation
Managing the webservice backends via the server environment is an explicit choice: installing webservice and server_environment together must not enable it, e.g. when the backends are configured otherwise (confidoo, UI, ...).
Contributor
|
Hi @etobella, |
ivantodorovich
approved these changes
Nov 5, 2026
ivantodorovich
left a comment
Contributor
There was a problem hiding this comment.
Indeed, it's a mistake. It shuold've just been a post-migration script that installs it to keep the previous behavior (server env installed)
Contributor
Author
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 33fa778. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managing the webservice backends via the server environment is an explicit choice: installing webservice and server_environment together must not enable it, e.g. when the backends are configured otherwise (confidoo, UI, ...).
It was made auto_install here #146 but IMO is wrong because it forces its usage even if you use server env for other modules only.