Repository navigation
[19.0][FIX] webservice: authorization URL and scope required for the web application flow - #199
Open
parabol123654 wants to merge 1 commit into
Open
parabol123654 wants to merge 1 commit into
parabol123654 wants to merge 1 commit into
Conversation
Contributor
|
Hi @etobella, |
…plication flow The required condition of the authorization URL and the scope used the flow value 'authorization_code', which does not exist (the value is 'web_application'), so they were never required although the authorization redirect needs them. Forward port of OCA#197.
parabol123654
force-pushed
the
19.0-fix-webservice-web-application-required
branch
from
November 3, 2026 18:16
3b63b64 to
c836596
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port of #197 (merged on 18.0).
In
webservice/views/webservice_backend.xml, therequiredattribute ofoauth2_scopeandoauth2_authorization_urlchecksoauth2_flow == 'authorization_code'. That value does not exist: the selection values arebackend_applicationandweb_application. As a result, the two fields are never required, although the authorization redirect needs them. The fix uses'web_application'.Test:
test_web_application_required_fields_with_ui, the same test as in #197. It fails without the fix on 18.0. I could not run it locally on 19.0 (no test environment on this machine right now); CI runs it here.