Skip to content

Shop Pay: payments are captured when the order is placed - #72

Merged
next-devin merged 5 commits into
mainfrom
shop-pay-capture
Oct 28, 2026
Merged

next-devin merged 5 commits into
mainfrom
shop-pay-capture

Conversation

@next-devin

@next-devin next-devin commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

NEXT now captures Shop Pay payments as soon as the order is placed, whatever the Shop Pay store's capture setting in Shopify. The live page still says payments are authorized at checkout and captured later within 7 days.

Changes

  • "Managing Shop Pay Orders" now says payments are captured when the order is placed, and refunds (full or partial) are made from the transaction in NEXT.
  • The capture and void bullets are removed.

This replaces the earlier version of this PR, which added a "Capture payments at checkout" Shopify setup step. That step is no longer needed and is removed.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
nextcommerce-docs 94305df Commit Preview URL

Branch Preview URL
Oct 28 2026, 09:06 AM

@kilo-code-bot

kilo-code-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
content/docs/features/payments/shop-pay.mdx 91 The bare **Settings > Payments** path collides with the NEXT admin menu of the same name used on line 45 of the same page; the page's own convention (line 23) qualifies it as "your Shopify admin"
content/docs/features/payments/shop-pay.mdx 91 The new "there's nothing to capture or void" clause rules out void without saying what replaces it when a Shop Pay order is cancelled (a refund on an already-captured payment, which is a different fee outcome than voiding an authorization)
Files Reviewed (1 file)
  • content/docs/features/payments/shop-pay.mdx - 2 issues

Notes

  • Incremental review of f25fb42..94305df; the only change is line 91 of content/docs/features/payments/shop-pay.mdx.
  • The capture-timing wording, the Shopify capture-setting statement, and the refund path now read correctly for the storefront, NEXT Campaigns, and Admin API external-checkout flows this page documents. The link target ### Transactions Detail View exists at content/docs/features/payments/index.mdx:128 and matches the href used in order-management.mdx, disputes-guide.mdx, and authorize-and-capture-payments.mdx.
  • Dropping the NEXT delayed-capture sentence is correct: Auth/Capture is configured per gateway (content/docs/features/payments/authorize-and-capture-payments.mdx:35) and Shop Pay has no gateway (shop-pay.mdx:7), so no NEXT setting applies to it.
  • Docs-only correction; no changelog entry applies (docs/MAINTENANCE.md covers release entries, and no inbound anchor links to the removed "Capture payments at checkout" section remain in the repo).
  • No security, runtime, or API impact.

Fix these issues in Kilo Cloud

Previous Review Summaries (4 snapshots, latest commit f25fb42)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit f25fb42)

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 3
Issue Details (click to expand)

SUGGESTION

File Line Issue
content/docs/features/payments/shop-pay.mdx 91 "delayed-capture settings" doesn't match any NEXT setting name (the real controls are gateway-level Auto Capture on Fulfillment and Delayed Capture Days) and duplicates line 7
content/docs/features/payments/shop-pay.mdx 91 Page no longer says Shop Pay transactions have no authorization to capture or void, while pointing at a Transactions Detail View whose Actions menu offers both
content/docs/features/payments/shop-pay.mdx 91 "whatever Payment capture method" drops the definite article and reads as a concession; the setting's location (Settings > Payments) is no longer given
Files Reviewed (1 file)
  • content/docs/features/payments/shop-pay.mdx - 3 issues

Notes

  • Incremental review of 4e270e7..f25fb42; the only change is line 91, which now states capture timing, the Shopify capture setting, NEXT delayed-capture settings, and the refund path.
  • All three findings from the previous review are resolved in f25fb42: capture timing now reads "as soon as the customer completes payment" (correct for the storefront, NEXT Campaigns, and Admin API external-checkout flows this page documents), the Shopify Payment capture method setting is stated to be irrelevant, and the refund instruction links the Transactions Detail View as the other payments pages do.
  • The new link target is valid: ### Transactions Detail View exists at content/docs/features/payments/index.mdx:128, and /docs/features/payments#transactions-detail-view matches the href already used in order-management.mdx, disputes-guide.mdx, and authorize-and-capture-payments.mdx.
  • Checked AGENTS.md and docs/MAINTENANCE.md: docs-only correction, so no changelog entry or code-impact requirement applies; the removed "Capture payments at checkout" section has no remaining inbound anchor links in the repo.
  • No security, runtime, or API impact.

Fix these issues in Kilo Cloud

Previous review (commit 4e270e7)

Status: 3 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 2
Issue Details (click to expand)

WARNING

File Line Issue
content/docs/features/payments/shop-pay.mdx 91 "captured as soon as the order is placed" is inaccurate for the Admin API / NEXT Campaigns flows this page also documents, where the order is created before the customer pays

SUGGESTION

File Line Issue
content/docs/features/payments/shop-pay.mdx 91 Shopify's Payment capture method setting is no longer mentioned anywhere after the setup step was removed; state that capture happens regardless of that setting
content/docs/features/payments/shop-pay.mdx 91 "transaction detail page" should link to the Transactions Detail View, as the other payments pages do
Files Reviewed (1 file)
  • content/docs/features/payments/shop-pay.mdx - 3 issues

Notes

  • Incremental review of 5f3f172..4e270e7. The only net change against the base branch is line 91, which replaces the old "always authorized at checkout and captured later" wording and the Capture/Void/Refund bullet list with the single capture-at-order-placement paragraph.
  • Both previous SUGGESTIONs (ambiguous "it" in the callout at line 36, inconsistent "Manually" phrasing at line 101) are resolved: that text was deleted in 4e270e7 and no equivalent wording remains elsewhere in the file.
  • The removed "Capture payments at checkout" section leaves the "Shop Pay Requirements" flow coherent (Sign up → Activate Shopify Payments → Add domain → Copy credentials), and no in-repo page links to the removed #capture-payments-at-checkout anchor.
  • Verified against AGENTS.md and docs/MAINTENANCE.md: no changelog entry or build/link-validation requirement applies to this correction (docs-only, internal repo). No security or runtime impact.

Fix these issues in Kilo Cloud

Previous review (commit 5f3f172)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • content/docs/features/payments/shop-pay.mdx

Notes

  • Both previous findings are resolved in the incremental commit 5f3f172: line 37 now reads "as it does for gateway payments" (ambiguous pronoun removed) and is split into two sentences; line 101 now uses "is set to capture Manually", matching the warning callout.
  • The warning callout, the setup step, and the "Managing Shop Pay Orders" paragraph consistently reference the same Shopify Payment capture method setting.
  • Docs-only change; no security, runtime, or API-impact concerns.

Previous review (commit 24ca368)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
content/docs/features/payments/shop-pay.mdx 36 Ambiguous "it" in "the way it does for gateways" + comma splice in "each payment is only authorized, and you must capture it within 7 days"
content/docs/features/payments/shop-pay.mdx 101 Inconsistent phrasing with the callout: "captures manually" vs "is set to capture Manually"
Files Reviewed (1 file)
  • content/docs/features/payments/shop-pay.mdx - 2 issues

Notes

  • The change correctly adds a setup step for the Shopify capture-method setting and removes the now-incorrect blanket statement that Shop Pay payments are always authorized at checkout and captured later.
  • The new section placement under ## Shop Pay Requirements matches the surrounding Shopify admin setup flow (Sign up → Activate Shopify Payments → Capture method → Add domain → Copy credentials).
  • Cross-references between the setup step (line 33, "Under Payment capture method"), the warning callout (line 36, "is set to capture Manually"), and the managing-orders paragraph (line 101) all align on the same Shopify setting.
  • No security, runtime, or API-impact issues found; this is a docs-only change.

Fix these issues in Kilo Cloud


Reviewed by minimax-m3.1-flash · Input: 52.6K · Output: 16.9K · Cached: 669.2K

@next-devin next-devin changed the title Shop Pay: set Shopify to capture at checkout Shop Pay: payments are captured when the order is placed Oct 28, 2026
@next-devin
next-devin merged commit b845e90 into main Oct 28, 2026
4 checks passed
@next-devin
next-devin deleted the shop-pay-capture branch October 28, 2026 09:16
* **Capture** an authorized payment. Only full captures are supported.
* **Void** (cancel) an authorization that hasn't been captured.
* **Refund** a captured payment, in full or in part.
Shop Pay payments are captured as soon as the customer completes payment, regardless of the **Payment capture method** your Shop Pay store uses in Shopify (**Settings > Payments**), so there's nothing to capture or void. You can refund a Shop Pay payment, in full or in part, from the [Transactions Detail View](/docs/features/payments#transactions-detail-view) in NEXT.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: The bare **Settings > Payments** path collides with the NEXT menu on this page

This page uses **Settings > Payments** for two different admins: line 23 points at Shopify ("In your Shopify admin, go to Settings > Payments"), and line 45 points at NEXT ("Go to Settings > Payments, find Shop Pay"). The new parenthetical drops the "your Shopify admin" qualifier that line 23 uses, so it reads like the NEXT path — where no capture setting exists. Qualify it the way line 23 does:

Suggested change
Shop Pay payments are captured as soon as the customer completes payment, regardless of the **Payment capture method** your Shop Pay store uses in Shopify (**Settings > Payments**), so there's nothing to capture or void. You can refund a Shop Pay payment, in full or in part, from the [Transactions Detail View](/docs/features/payments#transactions-detail-view) in NEXT.
Shop Pay payments are captured as soon as the customer completes payment, regardless of the **Payment capture method** your Shop Pay store uses in Shopify (**Settings > Payments** in your Shopify admin), so there's nothing to capture or void. You can refund a Shop Pay payment, in full or in part, from the [Transactions Detail View](/docs/features/payments#transactions-detail-view) in NEXT.

* **Capture** an authorized payment. Only full captures are supported.
* **Void** (cancel) an authorization that hasn't been captured.
* **Refund** a captured payment, in full or in part.
Shop Pay payments are captured as soon as the customer completes payment, regardless of the **Payment capture method** your Shop Pay store uses in Shopify (**Settings > Payments**), so there's nothing to capture or void. You can refund a Shop Pay payment, in full or in part, from the [Transactions Detail View](/docs/features/payments#transactions-detail-view) in NEXT.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Say what replaces void when a Shop Pay order is cancelled

The new clause rules out capture and void, but leaves the obvious next question unanswered: a merchant who cancels a Shop Pay order has no authorization to void, and the page does not say how the money comes back instead. The payments docs make this distinction explicit elsewhere — an authorization "can be voided at any time during the authorization period - usually without incurring a separate transaction fee" (authorize-and-capture-payments.mdx:19), while for a captured payment "Refunds are issued as refunds, not voids" (gateways/stripe-payment-intents.mdx:80). A Shop Pay payment is always captured, so cancelling one is a refund rather than a void. One clause here (for example, "Cancelling a Shop Pay order refunds the customer") would close the gap for merchants who previously relied on voiding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant