Repository navigation
Move NLE terminal dimension initialisation - #133
Merged
StephenOman merged 1 commit intoOct 25, 2026
Merged
Conversation
Collaborator
This is excellent! It means no dlopen/dlclose to reinitialize, which likely makes episode restarts a good deal faster. |
heiner
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetHack 5 has refactored all global variables into alphabetical structures. For example, all global variables starting with the letter 'a' are now in a structure called
ga(seedecl.h:141anddecl.c:1085). Initialising these global variables is now controlled by individual functions, so that the game engine can be totally initialised. Seedecl.c:1080for this initialisation function, calleddecl_globals_init.For NLE purposes, this initialisation occurs after the original initialisation of the terminal dimensions in
nle.c. This PR changes this as follows:gettty()for subsequent calls to the terminal. Adding it here innle.cavoids changes in NetHack code.Note: This NetHack 5 change opens the possibility for simplifying multiple runs of the game engine as the global variables could be reinitialised. This is out of the scope for NH5 upgrade.