Repository navigation
Check file existence before prompting for passwords - #87
Open
ben-harack wants to merge 1 commit into
Open
ben-harack wants to merge 1 commit into
ben-harack wants to merge 1 commit into
Conversation
Previously both passwords were prompted for before either input file's existence was checked, so a typo'd filename only surfaced after the user had already typed in (up to two) passwords. Move the keyfile resolution up and check input files and keyfiles up front, exiting immediately on a missing path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CksYookbdZ5Dz8h3cmvT4A
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both passwords were prompted for before either input file's existence was checked, so a typo'd filename only surfaced after the user had already typed in (up to two) passwords.
This moves keyfile resolution up and checks
INPUT-A,INPUT-B, and both keyfiles (if given) up front, exiting immediately withError: file not found: <path>on the first missing path — before any password prompt runs.Test plan
cargo build --release— clean, no new warningstest/test.kdbx/test/test2.kdbxfixtures with--passwords demopass)