Repository navigation
Hotfix 26.10.01: DataModel bound slack and Kitmaker proxy - #2285
Draft
ramakrishnap-nv wants to merge 6 commits into
Draft
ramakrishnap-nv wants to merge 6 commits into
ramakrishnap-nv wants to merge 6 commits into
Conversation
…nnel The nv-stg-ps proxy rejects the join with 'token expired or not found'. The Charon team confirmed the proxy should be ext-nv-stg-apps.teleport.sh. Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
_slack_from_data_model always read the rhs and row-type arrays, which are empty when a DataModel supplies its rows through set_constraint_lower_bounds/set_constraint_upper_bounds. With Cython bounds checking off this read out of bounds and returned a wrong slack or crashed. Use rhs and row types only when both have one entry per row; otherwise derive the slack from the lower and upper bounds, and return None when neither representation is complete. Fixes NVIDIA#2249 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
DataModel documents that lower/upper bounds win over rhs and row types when both are set, and the solver does the same. Check the bounds first so the slack matches the problem that was solved. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
The all-row-kinds test already covers a lower-bound-only row. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
…ypes A DataModel whose row types were set as a plain str, such as "GL", passed the length check but np.ascontiguousarray(..., dtype="S1") truncated it to one element, so _compute_slack_csr read the sense array out of bounds. get_ascii_row_types() already holds one int8 code per row, so use it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test e5af7c5 |
CI Test Summary✅ All 23 test job(s) passed. (1 skipped) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hotfix for 26.10.01, branched from the
v26.10.00release commit.DataModelconstraints set as lower/upper bounds (Fix slack for DataModel constraints given as lower/upper bounds #2253, closes [BUG] Out-of-bounds read when solving a DataModel with lower/upper constraint bounds #2249):Solveread the empty rhs/row-type arrays and returned a wrong slack. It now uses the bounds, orNonewhen neither representation is complete.mainvia ci: Kitmaker matrix, Teleport proxy fix and release follow-ups #2161):ext-nv-stg-apps.teleport.sh:443replacesnv-stg-ps.teleport.sh:443, which failed withtoken expired or not foundfor thev26.10.00publish jobs.The slack fix also goes to
mainthrough #2253, and the proxy fix is already there. No version bump is included.Checklist
v*tag and the Charon tunnel🤖 Generated with Claude Code