Skip to content

ci: Revert matrix_type overrides in for CUDA 13.4 - #2257

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
jameslamb:cuda-13.4-revert-matrix-types
Nov 3, 2026
Merged

rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
jameslamb:cuda-13.4-revert-matrix-types

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Contributes to rapidsai/build-planning#335

CUDA 13.4 is now part of the default pull-request and nightly matrices in shared-workflows,
so the temporary cuda-13-4-* matrix_type overrides are no longer needed.

ref: rapidsai/shared-workflows#679

@jameslamb jameslamb added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Nov 2, 2026
@copy-pr-bot

copy-pr-bot Bot commented Nov 2, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
jameslamb marked this pull request as ready for review November 2, 2026 21:54
@jameslamb
jameslamb requested a review from a team as a code owner November 2, 2026 21:54
@jameslamb
jameslamb requested a review from gforsyth November 2, 2026 21:54
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The build, pull-request, and test workflows replace CUDA 13.4-specific matrix selections with standard nightly or pull-request matrix types.

Changes: CI Matrix Configuration

Layer / File(s) Summary
Nightly build and test selections
.github/workflows/build.yaml, .github/workflows/test.yaml
Build and test jobs select the nightly matrix type instead of CUDA 13.4-specific matrix types.
Pull-request job selections
.github/workflows/pr.yaml
Jobs select the pull-request matrix type instead of CUDA 13.4-specific types. Jobs that previously selected both types now select only pull-request. The Java static-build matrix also selects pull-request.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • NVIDIA/cuopt#2241: Adds the CUDA 13.4 matrix overrides that this change removes from the same workflow files.
  • NVIDIA/cuopt#2247: Changes matrix selections in the same test workflows and retains CUDA-specific selections for a test job.

Suggested reviewers: ramakrishnap-nv

Merge Risk: Minimal · up to 88e14

The workflow changes safely replace temporary CUDA 13.4 selectors with the standard matrices, with no actionable merge-blocking risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: reverting temporary CUDA 13.4 matrix_type overrides in CI workflows.
Description check Passed The description explains why the overrides are removed and links the related planning issue and shared-workflows change.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/javascript/security/llm-output-code-execution-javascript.yml

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: NVIDIA/cuopt
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: ea0adad
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: d5128442-0998-46f2-8d60-a81ec62f4447
Commits

Reviewing files that changed from the base of the PR and between 8561607 and 88e1471.

Files selected for processing: 1
  • .github/workflows/pr.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Comment thread .github/workflows/pr.yaml Resolved
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

CI Test Summary

✅ All 21 test job(s) passed.

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@jameslamb

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 77e1971 into NVIDIA:main Nov 3, 2026
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants