Repository navigation
Conversation
The workflow only runs on pull_request, so sccache's GHA backend stores every object in a PR-scoped cache that other PRs can't read. Running it on pushes to main populates the base-branch scope, which PR runs can restore, so a new PR's first build no longer compiles from scratch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rt4UYn6zqR9uS7DWNGEBYx Signed-off-by: Apoorva Garg <271577+agarg21@users.noreply.github.com>
agarg21
marked this pull request as ready for review
October 21, 2026 16:17
Contributor
[Low impact] The PR appears safe to merge. SummaryAdds pushes to
Reviews (1) · Last reviewed commit: "Run minimum-versions build on pushes to ..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
minimum_versions.ymlonly runs onpull_request. sccache's GitHub Actions cache backend therefore stores every compiled object in a PR-scoped cache (refs/pull/<N>/merge), which no other PR can read. When we checked, the repo had 0 cache entries onmainand ~24.6k PR-scoped ones. As a result every new PR's first run compiles TE from scratch: ~2.6% sccache hit rate and ~60 min median wall time, versus ~10 min per job once that PR's own cache is warm.Running the workflow on pushes to
mainfills the base-branch cache scope, which PR runs can restore.Fixes # (none filed)
Type of change
Changes
push: branches: [main]to.github/workflows/minimum_versions.yml(3 lines).Measurement
Measured on a fork (agarg21/TransformerEngine), 3 fresh PRs per arm, all green:
Fork run IDs: before 39471922855, 39471924582, 39471927842; after 39496253340, 39496257361, 39496261774; warm-up push run 39482052619.
Caveats:
mainon GitHub-hosted runners, mostly warm after the first.Checklist:
Prepared with AI assistance (Claude) and measured on a fork. Opened as a draft per AGENTS.md until the submitter has reviewed it. Commit is DCO signed-off.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Rt4UYn6zqR9uS7DWNGEBYx