Repository navigation
Support GroupedTensor autograd views and stream tracking - #3701
vthumbe1503 wants to merge 4 commits into
Conversation
[Medium impact] The PR appears safe to merge, with a non-blocking request to restore autograd regression coverage. Findings
SummaryThis PR adds shape-preserving autograd views for
Reviews (4) · Last reviewed commit: "remove unecessary test" · Reviewed by Greptile |
Signed-off-by: Varun Thumbe <vthumbe@nvidia.com>
Signed-off-by: Varun Thumbe <vthumbe@nvidia.com>
| torch.manual_seed(seed) | ||
| torch.cuda.manual_seed(seed) | ||
|
|
||
| def test_record_stream_tracks_grouped_buffers(self, monkeypatch) -> None: |
There was a problem hiding this comment.
Autograd views lose test coverage
Removing test_autograd_identity_supports_varying_shapes drops the direct regression test for the autograd views added by this PR. The remaining tests in test_grouped_tensor.py do not check grad_fn or backward through these views. Restore this test, or equivalent coverage, so changes that break shared buffers or gradient propagation are caught.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: