Repository navigation
feat(supervisor): stream HTTP session hook uploads on the plain-HTTP forward proxy #5086
Description
User Story
As an operator running an HTTP session hook that streams request bodies (for example a signing or redaction stage), I want plain-HTTP requests sent through the forward proxy to behave like requests on the L7 relay, so that uploads larger than 4 MiB are not denied depending on how the sandbox reached the endpoint.
Problem Statement
HTTP session hooks have no total size cap on STREAM request bodies on the L7 relay paths. The plain-HTTP forward proxy (ForwardMiddlewarePipeline::apply in crates/openshell-supervisor-network/src/proxy.rs) always passes RequestBodyDelivery::WITHHOLD, because it writes the request upstream as one buffer. The preflight therefore advertises limits.max_output_body_bytes of 4 MiB (MAX_MIDDLEWARE_PAYLOAD_BYTES), and a larger upload that matches a session request hook fails with failure_code: body_over_limit.
The limit is documented in Supported Operations (forward-proxy requests buffer output, 4 MiB), but the same hook behaves differently depending on the path a request takes. There is also no test covering the forward-proxy denial.
Raised in review of #4359: #4359 (comment)
Impact / Why This Matters
- Inconsistent behavior for one middleware config: an upload over 4 MiB succeeds via the L7 relay and fails via the forward proxy.
- It undercuts the "no total size cap" goal of HTTP session hooks for clients that use
HTTP_PROXYwith plain HTTP.
Proposed Design
- Add a test now: a forward-proxy upload over 4 MiB that matches a session request hook is denied with
failure_code: body_over_limit, and the upstream sees nothing. - Stream middleware output on the forward proxy, like the REST relay, when the route needs no body-wide work (no SigV4 signing, body credential rewrite, or body-aware L7 re-evaluation such as JSON-RPC/MCP/GraphQL). Keep
WITHHOLDwith its route limit for those cases. - Update the Supported Operations limits text once forward-proxy streaming lands.
Acceptance Criteria
- A test covers the 4 MiB forward-proxy denial (
body_over_limit, nothing forwarded). - A plain-HTTP forward-proxy upload over 4 MiB through a STREAM session request stage succeeds on routes that need no body-wide work, with
max_output_body_bytesunset in the preflight. - Routes that still need the whole body keep their documented limits.
- Docs describe the forward-proxy behavior.
Alternatives Considered
- Keep buffering and only document the limit. That leaves the path-dependent behavior in place.
Agent Investigation
proxy.rsForwardMiddlewarePipeline::applycallsapply_request_with_delivery(..., RequestBodyDelivery::WITHHOLD)with the comment "The forward proxy writes the request as one buffer, so middleware output is withheld and inlined."- The L7 REST relay chooses delivery per route via
request_body_delivery(config)inl7/relay.rs. - Docs:
docs/extensibility/supervisor-middleware/operations.mdx(request output buffering paragraph) already lists the forward proxy among buffered paths.
Activity