Repository navigation
Update logic to prevent deprecation warnings (3.12+) - #140
Merged
sadielbartholomew merged 7 commits intoOct 23, 2026
Merged
sadielbartholomew merged 7 commits into
sadielbartholomew merged 7 commits into
Conversation
sadielbartholomew
changed the title
Member
Author
|
Some of the image comparison tests fails (two streamplot cases) but I've realised it isn't helpful to know they failed without being able to see/access them, so also adding a new step to the image comparison workflow to store those for a set amount of time which I've set at 7 days (this can be reviewed over time). Closing and re-opening to test, aiming to get those generated plots to eyeball. |
Member
Author
|
All deprecation warnings gone bar though exceptions noted, all local and CI tests passing and artifacts are successfully generated for the image comparison test jobs. So all good, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #72 (where the final warning noted in my comment #72 (comment) emerges from cfdm so will be fixed over in that codebase). There may be other instances of deprecated logic but I will fix those as and when they are noticed - this is to address the backlog of deprecation warnings.