Repository navigation
test: run subscription-controller on Vitest - #10555
Open
cryptodev-2s wants to merge 1 commit into
Open
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
cryptodev-2s
added this pull request to stack #10557
September 28, 2026 20:19
2 of 4 tasks
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
September 29, 2026 08:11
b64be55 to
8721c5d
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
September 29, 2026 08:11
4949720 to
4a6a4a2
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
September 29, 2026 09:02
8721c5d to
8b414fc
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
September 29, 2026 09:02
4a6a4a2 to
8a4ccb8
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
September 29, 2026 14:38
8b414fc to
807c7f5
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
September 29, 2026 14:38
8a4ccb8 to
4204cd4
Compare
cryptodev-2s
removed this pull request from stack #10557
September 29, 2026 14:40
cryptodev-2s
added this pull request to stack #10578
September 29, 2026 14:41
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
September 30, 2026 07:04
807c7f5 to
356fffc
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
2 times, most recently
from
October 5, 2026 10:48
082d1f4 to
8421df4
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 5, 2026 10:48
356fffc to
6027196
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 12, 2026 14:02
6027196 to
77482d5
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 12, 2026 14:02
8421df4 to
534eb2b
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 12, 2026 15:43
77482d5 to
72c543c
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 12, 2026 15:43
534eb2b to
4c40019
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 14, 2026 09:24
72c543c to
041de24
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 14, 2026 09:24
4c40019 to
fd50cd7
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 14, 2026 12:47
041de24 to
464132b
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
2 times, most recently
from
October 14, 2026 12:53
2c5e08a to
4e68519
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 14, 2026 18:11
1f1d11f to
d6ffd65
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
2 times, most recently
from
October 14, 2026 20:18
2ff098a to
f352b76
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 14, 2026 20:37
d5ff385 to
8ebcdfa
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 14, 2026 20:37
f352b76 to
5e08c84
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 14, 2026 20:59
8ebcdfa to
910c9b2
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
2 times, most recently
from
October 14, 2026 21:27
9b4e972 to
2e9d2ec
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 14, 2026 22:48
10f6716 to
f7ae283
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 14, 2026 22:48
2e9d2ec to
3f2a8dd
Compare
cryptodev-2s
removed this pull request from stack #10578
October 14, 2026 22:51
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f2a8dd. Configure here.
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 10:36
f7ae283 to
53d230f
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 15, 2026 10:36
3f2a8dd to
5cbd6b0
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 11:20
53d230f to
8fd33d9
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 15, 2026 11:20
5cbd6b0 to
54e7d4c
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 11:50
8fd33d9 to
c27cc50
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 15, 2026 11:50
54e7d4c to
2837724
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 12:20
c27cc50 to
b2ad15e
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 15, 2026 12:20
2837724 to
cffacfe
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 13:21
b2ad15e to
845a892
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 15, 2026 13:21
cffacfe to
0a7eb9a
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 14:48
845a892 to
f260b1e
Compare
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 15, 2026 14:48
0a7eb9a to
13fd51b
Compare
cryptodev-2s
changed the base branch from
test/vitest-phishing-controller
to
test/vitest-setup
October 15, 2026 14:56
cryptodev-2s
force-pushed
the
test/vitest-subscription-controller
branch
from
October 15, 2026 15:38
13fd51b to
9f5da69
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Moves
@metamask/subscription-controllerto Vitest. One of a stack on top of #10546, which added Vitest without migrating anything.Add
vitest.config.mts, deletejest.config.cjs, swap the test scripts and dev dependencies, point the package tsconfig off the repo widetypes: ["jest"], and rewrite the test files (jest.*tovi.*,jest.Mockedto the imported Vitest type,requireActualto an awaitedimportActual, and an explicitvitestimport per file sinceglobalsis off).The
jest.environment.cjshere only exposedcrypto, which Node provides, so it is gone rather than ported.Tests pass with coverage thresholds enforced.
yarn lintandyarn constraintsare green on this branch alone.References
Checklist
no-changeloglabel.Note
Low Risk
Test-only and tooling changes; production subscription-controller code is unchanged.
Overview
Migrates
@metamask/subscription-controllerfrom Jest to Vitest, aligning it with the shared package Vitest setup from the monorepo stack.Test runner and config: Removes
jest.config.cjsand the customjest.environment.cjs(Web Crypto polyfill). Addsvitest.config.mjswith 100% coverage thresholds (same as the old Jest config).package.jsontest scripts now callvitest; Jest-related devDependencies are dropped in favor ofvitest ^5.Test code: All
*.test.tsfiles import fromvitestexplicitly (globalsoff), replacejest.*withvi.*, use VitestMocktypes, and switch timer helpers toadvanceTimefromtests/vitest/helpers.ts. Packagetsconfig.jsonsets"types": []so repo-wide Jest types do not apply.Repo wiring:
@metamask/subscription-controlleris removed from the Jest package list intest-runners.cjs.oxlint-suppressions.jsonis updated for the new lint profile (includingvitest/no-conditional-in-testwhere needed).Reviewed by Cursor Bugbot for commit 9f5da69. Bugbot is set up for automated code reviews on this repo. Configure here.