Repository navigation
test: run phishing-controller on Vitest - #10554
Open
cryptodev-2s wants to merge 1 commit into
Open
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
cryptodev-2s
added this pull request to stack #10557
September 28, 2026 20:19
2 of 4 tasks
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
September 29, 2026 08:11
b64be55 to
8721c5d
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
September 29, 2026 08:11
b92fe81 to
175e025
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
September 29, 2026 09:02
8721c5d to
8b414fc
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
2 times, most recently
from
September 29, 2026 14:38
186a8bd to
69b48d1
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
September 29, 2026 14:38
8b414fc to
807c7f5
Compare
cryptodev-2s
removed this pull request from stack #10557
September 29, 2026 14:40
cryptodev-2s
added this pull request to stack #10578
September 29, 2026 14:41
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
September 30, 2026 07:04
69b48d1 to
289154f
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 5, 2026 10:48
356fffc to
6027196
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 5, 2026 10:48
289154f to
3cec491
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 12, 2026 14:02
3cec491 to
eb6905d
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 12, 2026 15:43
77482d5 to
72c543c
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
2 times, most recently
from
October 14, 2026 09:24
425f889 to
b5450af
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 14, 2026 09:24
72c543c to
041de24
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 14, 2026 12:47
b5450af to
e837efa
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 14, 2026 12:53
464132b to
f67889e
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 14, 2026 13:44
d77b580 to
6224c52
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 14, 2026 18:11
1f1d11f to
d6ffd65
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 14, 2026 18:11
0bec1e3 to
aecebdc
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 14, 2026 20:18
d6ffd65 to
d5ff385
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 14, 2026 20:18
aecebdc to
3b9f474
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 14, 2026 20:37
d5ff385 to
8ebcdfa
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
2 times, most recently
from
October 14, 2026 20:59
265b5e5 to
ac1e48d
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 14, 2026 21:27
910c9b2 to
10f6716
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
2 times, most recently
from
October 14, 2026 22:48
5e8aeea to
ef5f527
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 14, 2026 22:48
10f6716 to
f7ae283
Compare
cryptodev-2s
removed this pull request from stack #10578
October 14, 2026 22:51
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 15, 2026 10:36
ef5f527 to
86786bb
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 15, 2026 11:20
53d230f to
8fd33d9
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 15, 2026 11:20
86786bb to
25334b8
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 11:50
8fd33d9 to
c27cc50
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
2 times, most recently
from
October 15, 2026 12:20
3126f77 to
f31c96c
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 12:20
c27cc50 to
b2ad15e
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 15, 2026 13:21
f31c96c to
e5aee1b
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 15, 2026 14:48
845a892 to
f260b1e
Compare
cryptodev-2s
force-pushed
the
test/vitest-controller-utils
branch
from
October 15, 2026 14:48
e5aee1b to
db2b678
Compare
cryptodev-2s
changed the base branch from
test/vitest-controller-utils
to
test/vitest-setup
October 15, 2026 14:56
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
2 times, most recently
from
October 15, 2026 20:07
125948f to
215c496
Compare
cryptodev-2s
force-pushed
the
test/vitest-phishing-controller
branch
from
October 15, 2026 23:52
215c496 to
0fb9fa5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/phishing-controllerto Vitest. One of a stack on top of #10546, which added Vitest without migrating anything.Add
vitest.config.mts, deletejest.config.cjs, swap the test scripts and dev dependencies, point the package tsconfig off the repo widetypes: ["jest"], and rewrite the test files (jest.*tovi.*,jest.Mockedto the imported Vitest type,requireActualto an awaitedimportActual, and an explicitvitestimport per file sinceglobalsis off).Tests pass with coverage thresholds enforced.
yarn lintandyarn constraintsare green on this branch alone.References
Checklist
no-changeloglabel.Note
Low Risk
Test-only migration with no runtime or API changes; risk is limited to CI/local test behavior if Vitest config diverges from the old Jest setup.
Overview
Migrates
@metamask/phishing-controllerfrom Jest to Vitest with no production code changes.The package drops
jest.config.cjsand Jest-related devDependencies, addsvitest.config.mjs(same coverage thresholds as before), and switchestest/test:watchscripts to Vitest.tsconfig.jsonsetscompilerOptions.typesto[]so repo-wide Jest types do not apply under Vitest without globals.All
*.test.tsfiles are updated to import fromvitestand usevi.*instead ofjest.*(mocks, spies, fake timers,importActual).@metamask/phishing-controlleris removed from the Jest allowlist intest-runner-package-map.cjs, andoxlint-suppressions.jsonis adjusted for the new setup.Reviewed by Cursor Bugbot for commit 0fb9fa5. Bugbot is set up for automated code reviews on this repo. Configure here.