Repository navigation
test: run sample-controllers on Vitest - #10550
Open
cryptodev-2s wants to merge 1 commit into
Open
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
cryptodev-2s
added this pull request to stack #10557
September 28, 2026 20:19
2 of 4 tasks
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
September 29, 2026 08:11
57a9877 to
e91bdd0
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
2 times, most recently
from
September 29, 2026 09:02
67053a2 to
b3e82c5
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
2 times, most recently
from
September 29, 2026 14:38
ad263be to
c679083
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
September 29, 2026 14:38
b3e82c5 to
a1d4e04
Compare
cryptodev-2s
removed this pull request from stack #10557
September 29, 2026 14:40
cryptodev-2s
added this pull request to stack #10578
September 29, 2026 14:41
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
September 30, 2026 07:04
c679083 to
80c7790
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
2 times, most recently
from
October 5, 2026 10:48
364aa75 to
63eccab
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 5, 2026 10:48
80c7790 to
23f8c46
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 12, 2026 14:02
23f8c46 to
dffdbe0
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 12, 2026 14:02
63eccab to
71c2fed
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 12, 2026 15:43
dffdbe0 to
fe8b81c
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 12, 2026 15:43
71c2fed to
326b876
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 14, 2026 09:23
fe8b81c to
4c4749e
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 14, 2026 09:23
326b876 to
253b29c
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 14, 2026 12:47
4c4749e to
642b296
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
2 times, most recently
from
October 14, 2026 12:53
bfbd149 to
0ca3777
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 14, 2026 13:44
d3960d8 to
8112a4b
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 14, 2026 13:44
0ca3777 to
ac3840f
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 14, 2026 18:11
b549cff to
9373d55
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 14, 2026 18:11
a0a00fc to
9be48e8
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 14, 2026 20:18
9373d55 to
b2c633b
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 14, 2026 20:18
9be48e8 to
7d3768b
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 14, 2026 20:37
b2c633b to
acb7896
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
2 times, most recently
from
October 14, 2026 20:59
60962aa to
fa046eb
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 14, 2026 20:59
acb7896 to
2369da2
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 14, 2026 21:27
fa046eb to
f9f28e3
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
2 times, most recently
from
October 14, 2026 22:48
68df0bc to
e32a39c
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 14, 2026 22:48
f9f28e3 to
7e7d023
Compare
cryptodev-2s
removed this pull request from stack #10578
October 14, 2026 22:51
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 15, 2026 10:36
e32a39c to
d168357
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 15, 2026 10:36
7e7d023 to
0b21fde
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 15, 2026 11:20
d168357 to
e25274a
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
2 times, most recently
from
October 15, 2026 11:50
a196bd2 to
8e3abbd
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
2 times, most recently
from
October 15, 2026 12:20
4b735f3 to
8b861e8
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
2 times, most recently
from
October 15, 2026 13:21
56d6d16 to
fe67e0d
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 15, 2026 13:21
8b861e8 to
55fa07c
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 15, 2026 14:48
fe67e0d to
d7f992a
Compare
cryptodev-2s
force-pushed
the
test/vitest-approval-controller
branch
from
October 15, 2026 14:48
55fa07c to
b9164d4
Compare
cryptodev-2s
changed the base branch from
test/vitest-approval-controller
to
test/vitest-setup
October 15, 2026 14:56
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
2 times, most recently
from
October 15, 2026 20:07
46d275e to
36e6deb
Compare
cryptodev-2s
force-pushed
the
test/vitest-sample-controllers
branch
from
October 15, 2026 23:52
36e6deb to
1cb5369
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/sample-controllersto Vitest. One of a stack on top of #10546, which added Vitest without migrating anything.Add
vitest.config.mts, deletejest.config.cjs, swap the test scripts and dev dependencies, point the package tsconfig off the repo widetypes: ["jest"], and rewrite the test files (jest.*tovi.*,jest.Mockedto the imported Vitest type,requireActualto an awaitedimportActual, and an explicitvitestimport per file sinceglobalsis off).Tests pass with coverage thresholds enforced.
yarn lintandyarn constraintsare green on this branch alone.References
Checklist
no-changeloglabel.Note
Low Risk
Test infrastructure and devDependencies only; library behavior and public API are unchanged.
Overview
Migrates
@metamask/sample-controllersfrom Jest to Vitest as the first package on the shared Vitest setup (stacked on the repo-wide Vitest foundation).The package drops
jest.config.cjsand addsvitest.config.mjs(merged fromvitest.config.packages.mjs) with the same 100% coverage thresholds.package.jsonswitchestest/test:watch/ related scripts to Vitest and swaps Jest devDependencies forvitest.Test-only updates: explicit
vitestimports (globals off),jest.*→vi.*for mocks/timers/spies, andflushPromisesfromtests/vitest/helpers.js.tsconfig.jsonsetstypes: []so repo-wide Jest types do not apply.@metamask/sample-controllersis removed fromtest-runner-package-map.cjs(no longer run as a Jest package).oxlint-suppressions.jsonis updated for the new test file lint entries.No production/runtime code changes.
Reviewed by Cursor Bugbot for commit 1cb5369. Bugbot is set up for automated code reviews on this repo. Configure here.