Repository navigation
test: run polling-controller on Vitest - #10548
Open
cryptodev-2s wants to merge 1 commit into
Open
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
cryptodev-2s
added this pull request to stack #10557
September 28, 2026 20:19
2 of 4 tasks
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
September 29, 2026 08:11
c4fcfb2 to
54879b9
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
September 29, 2026 08:11
32d3ba1 to
452938a
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
September 29, 2026 09:02
54879b9 to
79b9e14
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
2 times, most recently
from
September 29, 2026 14:38
0fee19b to
c1e577a
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
September 29, 2026 14:38
79b9e14 to
12980e9
Compare
cryptodev-2s
removed this pull request from stack #10557
September 29, 2026 14:40
cryptodev-2s
added this pull request to stack #10578
September 29, 2026 14:41
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
September 30, 2026 07:04
12980e9 to
d248c2e
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
September 30, 2026 07:04
c1e577a to
021450c
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 5, 2026 10:48
d248c2e to
dbc8afc
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 5, 2026 10:48
021450c to
26238b4
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 12, 2026 14:02
dbc8afc to
79ecc80
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
2 times, most recently
from
October 12, 2026 15:43
5dd5aff to
e5b70e8
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 12, 2026 15:43
79ecc80 to
56ec0c8
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 14, 2026 09:23
e5b70e8 to
353997d
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 14, 2026 09:23
56ec0c8 to
0027854
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 14, 2026 12:47
353997d to
cfedd2a
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
2 times, most recently
from
October 14, 2026 12:53
52c697b to
342e176
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 14, 2026 13:44
aece612 to
860b7b9
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 14, 2026 13:44
342e176 to
09e3b96
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 14, 2026 15:41
860b7b9 to
1a307d4
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 14, 2026 17:53
14923d7 to
bf6fb8a
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
2 times, most recently
from
October 14, 2026 18:11
30e1dbc to
444c0a0
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 14, 2026 18:11
bf6fb8a to
2d85bf5
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 14, 2026 20:18
444c0a0 to
80d5b4d
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
2 times, most recently
from
October 14, 2026 20:37
3657884 to
72146c5
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
2 times, most recently
from
October 14, 2026 20:59
7d84ca4 to
5f28508
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 14, 2026 20:59
72146c5 to
85f9712
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 14, 2026 21:27
5f28508 to
dee3bae
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
2 times, most recently
from
October 14, 2026 22:48
4ada28b to
eb6f138
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 14, 2026 22:48
dee3bae to
80f9420
Compare
cryptodev-2s
removed this pull request from stack #10578
October 14, 2026 22:51
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 15, 2026 10:36
80f9420 to
ebb06ea
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 15, 2026 10:36
eb6f138 to
5d2a8a8
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 15, 2026 11:20
ebb06ea to
98e9897
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 15, 2026 11:20
5d2a8a8 to
42f3009
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 15, 2026 11:50
98e9897 to
f71e894
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
2 times, most recently
from
October 15, 2026 12:20
3ca6b4f to
d648832
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
2 times, most recently
from
October 15, 2026 13:21
00ff6ed to
b438676
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 15, 2026 13:21
d648832 to
4a2b96c
Compare
cryptodev-2s
force-pushed
the
test/vitest-base-controller
branch
from
October 15, 2026 14:48
b438676 to
2c1c3f8
Compare
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 15, 2026 14:48
4a2b96c to
2bbfd60
Compare
cryptodev-2s
changed the base branch from
test/vitest-base-controller
to
test/vitest-setup
October 15, 2026 14:56
cryptodev-2s
force-pushed
the
test/vitest-polling-controller
branch
from
October 15, 2026 15:38
2bbfd60 to
6ca0307
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Moves
@metamask/polling-controllerto Vitest. One of a stack on top of #10546, which added Vitest without migrating anything.Add
vitest.config.mts, deletejest.config.cjs, swap the test scripts and dev dependencies, point the package tsconfig off the repo widetypes: ["jest"], and rewrite the test files (jest.*tovi.*,jest.Mockedto the imported Vitest type,requireActualto an awaitedimportActual, and an explicitvitestimport per file sinceglobalsis off).Tests pass with coverage thresholds enforced.
yarn lintandyarn constraintsare green on this branch alone.References
Checklist
no-changeloglabel.Note
Low Risk
Test-runner and devDependency changes only; runtime package code is unchanged.
Overview
Migrates
@metamask/polling-controllerfrom Jest to Vitest as part of the repo-wide test runner rollout.Test tooling: Removes
jest.config.cjsand Jest-related devDependencies; addsvitest.config.mjs(merged with the shared package config) with the same coverage thresholds as before. Packagetestscripts now invoke Vitest (vitest run,watch, etc.).Tests:
StaticIntervalPollingController.test.tsswitches to explicit Vitest imports (vi,describe, …),vi.fn()/ fake timers instead of Jest, and sharedadvanceTimefromtests/vitest/helpers.jsinstead ofjestAdvanceTime.TypeScript / CI wiring: Package
tsconfig.jsonsetscompilerOptions.typesto[]so repo-wide Jest types are not pulled in.@metamask/polling-controlleris dropped fromPACKAGES_ON_JESTintest-runners.cjs, and the obsoletejest.config.cjsoxlint suppression is removed.No production controller source changes in this diff—only test and config updates.
Reviewed by Cursor Bugbot for commit 6ca0307. Bugbot is set up for automated code reviews on this repo. Configure here.