Skip to content

test: run base-controller on Vitest - #10547

Open
cryptodev-2s wants to merge 1 commit into
test/vitest-setupfrom
test/vitest-base-controller
Open

cryptodev-2s wants to merge 1 commit into
test/vitest-setupfrom
test/vitest-base-controller

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Moves @metamask/base-controller to Vitest.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
    • Not applicable, test only change. Carries the no-changelog label.
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
    • None.

Note

Low Risk
Test and tooling only; no changes to published runtime code or package APIs.

Overview
Migrates @metamask/base-controller from Jest to Vitest, following the shared monorepo Vitest setup (stacked on the parent PR).

The package drops jest.config.cjs and Jest-related devDependencies, adds vitest.config.mjs (including 100% coverage thresholds carried over from Jest), and updates package.json test scripts to vitest run / vitest watch. BaseController.test.ts switches to explicit Vitest imports (describe, expect, it, vi) and replaces jest.fn / jest.spyOn with vi.

tsconfig.json sets "types": [] so repo-wide Jest types do not apply under Vitest. @metamask/base-controller is removed from the Jest test-runner-package-map.cjs list and from the related oxlint-suppressions.json entry for the deleted Jest config.

Reviewed by Cursor Bugbot for commit 0f1768d. Bugbot is set up for automated code reviews on this repo. Configure here.

@cryptodev-2s
cryptodev-2s requested a review from a team as a code owner September 28, 2026 20:18
@cryptodev-2s
cryptodev-2s added this pull request to stack #10557 September 28, 2026 20:19
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch from 32d3ba1 to 452938a Compare September 29, 2026 08:11
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch 2 times, most recently from 0fee19b to c1e577a Compare September 29, 2026 14:38
@cryptodev-2s
cryptodev-2s removed this pull request from stack #10557 September 29, 2026 14:40
@cryptodev-2s
cryptodev-2s added this pull request to stack #10578 September 29, 2026 14:41
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch from c1e577a to 021450c Compare September 30, 2026 07:04
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch from 021450c to 26238b4 Compare October 5, 2026 10:48
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch 2 times, most recently from 5dd5aff to e5b70e8 Compare October 12, 2026 15:43
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-setup branch 2 times, most recently from dfc0615 to 39e0b86 Compare October 14, 2026 09:23
@cryptodev-2s
cryptodev-2s requested review from a team as code owners October 14, 2026 09:23
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch from e5b70e8 to 353997d Compare October 14, 2026 09:23
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch 2 times, most recently from cfedd2a to aece612 Compare October 14, 2026 12:53
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch 2 times, most recently from 860b7b9 to 1a307d4 Compare October 14, 2026 15:41
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch from 1a307d4 to f8dec51 Compare October 14, 2026 17:13
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch from f8dec51 to 30e1dbc Compare October 14, 2026 17:53
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch 2 times, most recently from 444c0a0 to 80d5b4d Compare October 14, 2026 20:18
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch 3 times, most recently from 5f28508 to dee3bae Compare October 14, 2026 21:27
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch from dee3bae to 80f9420 Compare October 14, 2026 22:48
@cryptodev-2s
cryptodev-2s removed this pull request from stack #10578 October 14, 2026 22:51
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch 2 times, most recently from ebb06ea to 98e9897 Compare October 15, 2026 11:20
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch 7 times, most recently from 8b9a525 to b48a4b7 Compare October 16, 2026 05:49
@cryptodev-2s
cryptodev-2s force-pushed the test/vitest-base-controller branch from b48a4b7 to 0f1768d Compare October 16, 2026 07:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant