Repository navigation
Fix column order and show/hide menu when SOC is excluded; honor display - #186
Merged
Merged
Conversation
…lay_diff_toggle - `display_soc_toggle = FALSE` dropped `soc_name` before `lt_move()` ran, so the figure columns lost their anchor and stayed after n/(%). The SOC column is now left out of the table data and the figures anchor on `name`. - Always show the "Show/Hide columns" menu, and no longer add a `soc_name` filter chip when SOC is excluded. - Deprecate `display_diff_toggle`: the risk-difference columns are always offered in the menu (hidden by default unless "diff" is in `display`). Co-Authored-By: Claude Code <noreply@anthropic.com>
The reactable version hid the proportion/difference figures and the n/(%) columns when absent from `format_ae_forestly(display=)`; the lt version ignored them. Build each figure only when listed, and include n/prop columns only when listed (proportions are still carried, hidden, when the dot plot reads them; CI bounds ship only with the error bar). Co-Authored-By: Claude Code <noreply@anthropic.com>
LittleBeannie
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185
display_soc_toggle = FALSEleft the figure columns after n/(%): the hidden SOC column was dropped beforelt_move()ran, so the move lost its anchor. The SOC column is now left out of the table entirely and the figures anchor on the term column.soc_namefilter chip no longer appears when SOC is excluded.display_diff_toggleis deprecated and ignored: the risk-difference columns are always offered in the menu (hidden by default unless"diff"is indisplay).format_lt_forestly()honorsdisplayagain forfig_prop,fig_diff,n, andprop, as the pre-ltversion did.Two commits: the first covers the #185 fixes and the deprecation, the second restores the
displaybehavior.🤖 Generated with Claude Code