Repository navigation
fix(canvas): mf-canvas-facts.py reads a note line's sides by the model's Mendix version (port of #595) - #605
Merged
Merged
Conversation
…l's Mendix version A note numbers its sides top 0, bottom 1, left 2, right 3 on Mendix 10, but like every other object (top 0, right 1, bottom 2, left 3) on Mendix 11. The script knew only the Mendix 10 table, so on a Mendix 11 model it read nearly every hand-drawn note line as leaving a side that faces away and printed a false NOTE-SIDE fact. It now reads _ProductVersion from the .mpr's _MetaData table: major 11 or higher uses the activity numbering; a version that cannot be read counts as Mendix 11. The first output line says which numbering was used. Fixture section V: the golden model stamped 10.x, and a Mendix 11 copy with the note sides renumbered as the upgrade does, give the same NOTE-SIDE result for each of the four sides. Ported from #595 onto current master; the only conflict was the CHANGELOG insertion point, and both lines are kept. Re-verified on master 0db1c0e. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LeNWZV2sVH62vkgfYh5u5
MendixMau
pushed a commit
that referenced
this pull request
Nov 1, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LeNWZV2sVH62vkgfYh5u5
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #595 by @saingge. Their commit is kept as authored, rebased onto current master; the only conflict was the CHANGELOG insertion point.
Direct lane
What changed and why: a note numbers its connection sides one way on Mendix 10 (top 0, bottom 1, left 2, right 3) and like every other object on Mendix 11 (top 0, right 1, bottom 2, left 3).
mf-canvas-facts.pyonly knew the Mendix 10 table, so on an 11.x model it produced false NOTE-SIDE and LINE facts. It now reads_MetaData._ProductVersionand says on its first output line which numbering it used. An unreadable version falls back to Mendix 11.Independent check of the Mendix 11 claim: upstream mxcli v0.29.0
sdk/microflows/microflows.go:418-420defines a note's sides as "0 top, 1 right, 2 bottom, 3 left — Studio Pro numbers a note's sides the same way". The Mendix 10 table is this tool's existing calibration from 10.24 screenshots.project-bin/mf-canvas-facts.pyand its fixture only; master has not touched either since #595's base. Its only consumer isverify-module.shrung 1c, which logs the output as INFO and parses no lines, so the new first line changes no verdictField evidence (from #595): 305 note lines from one app, matched across 10.24 and 11.15, give identical facts after the fix.
Re-verified on master 0db1c0e:
test-mf-canvas-facts.shpasses 22/0 here and 16/6 with master's script (all 6 new section V checks fail). That is T1, on the existing captured model.Review: pending independent review
Generated by Claude Code