Repository navigation
Conversation
PyVale can produce files where x and y are not integers. This used to be accepted by numpy <2.1.3, but load_text is more strict since 2.5.2. This commit changes the data format of x and y to be double. Fixes issue #157
New versions of PyVale use cost_zncc as column name
The pattern image size check required an exact match with the DIC map shape times binning. DIC packages round the number of subwindows differently, so the image can legitimately differ by a pixel or so. The check now accepts a range of sizes depending on the map format (DaVis rounds up; PyVale and OpenPIV round down). The error message reports the expected range.
rhysgt
marked this pull request as ready for review
October 21, 2026 09:37
mikesmic
reviewed
Oct 21, 2026
mikesmic
left a comment
mikesmic
left a comment
Collaborator
There was a problem hiding this comment.
I don't see why the name in the data_format needs to be changes to match the header of the file? The data is extracted later and the formatted is not passed on.
No need to change the data_format. It always maps the 7th column to 'cost', regardless of header.
Contributor
Author
|
Yup you're right. I though it was using file header for naming but it uses data_format to map them blindly to the given names. Reverted that change. |
mikesmic
approved these changes
Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[fix: Relax pattern image size check in HRDIC Map]
The pattern image size check required an exact match with the DIC map shape times binning. DIC packages round the number of subwindows differently, so the image can legitimately differ by a pixel or so. The check now accepts a range of sizes depending on the map format (DaVis rounds up; PyVale and OpenPIV round down). The error message reports the expected range.
[fix: Handle non-integer x, y in pyvale]
PyVale can produce files where x and y are not integers. This used to be accepted by numpy <2.1.3, but load_text is more strict since 2.5.2. This commit changes the data format of x and y to be double.
Fixes issue #157