Repository navigation
Conversation
The lint ran inside Lint docs, whose inputs don't cover .agents/skills/mz-release-signoff, so PR builds trimmed it away for skill-only changes and the failure first appeared on main. Give it its own step whose inputs are the skill and the metrics catalog it checks against, and keep it on main builds alongside the other lints. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mz-release-signoff metric lint never runs on PRs that only change the skill, so a broken skill reference is first caught on
main.Current failure mode
ci/test/lint-skill-metrics.shruns inside the Lint docs step (ci/test/lint-docs.sh).inputs: [doc/user, src/adapter/src/catalog, test/sqllogictest/autogenerated]. On PR builds,ci/mkpipeline.pytrims every step whose inputs didn't change..agents/skills/mz-release-signoff/**is not an input, so a skill-only PR never runs its own lint.mainbuilds always run Lint docs (it's in the keep-list inmkpipeline.py), so the failure first appears after merge. Lint docs also gatesdeploy-website, so a broken skill reference blocks the docs deploy too.mainfailed Lint docs for 11 builds (13:57–15:21 UTC on 2026-10-12, starting at 138591), until mz-release-signoff: pin reference-dashboards.md metric count to 26 #39769 fixed the pinned count.Change
lint-skill-metricsin the Lints group runsci/test/lint-skill-metrics.sh. Its inputs are.agents/skills/mz-release-signoffanddoc/user/data/metrics.yml, the catalog the lint resolves names against.ci/test/lint-docs.sh. A skill failure no longer blocks the website deploy, and a docs-only PR no longer runs the skill's pytest.lint-skill-metricsto themainkeep-list inci/mkpipeline.py. Without it, webhook builds onmainwould skip the new step like they skip every other non-lint step.Testing
ci/test/lint-skill-metrics.shpasses locally (4/4).git ls-fileson the new inputs matches mz-release-signoff: notes from the v26.43.0 production US sweep #39134's files; on the old Lint docs inputs it matches none of them.check-pipeline.shonly runs in CI, so this PR's own build is the first real pipeline check. Since it editsci/, that build runs untrimmed.🤖 Generated with Claude Code