[mrafie1]

Proposed Changes

Summary: The ExtensionsController#create method could create extensions for groupings in other courses (other than the current course) since it did not check params[:grouping_id].

Changes:

• Edited extensions_controller.rb to find valid groupings that have the current course_id and have the same params[:grouping_id];
• Instead of passing in a grouping_id, we pass in the grouping object (can be nil)
• If the object is nil, the extension will fail to save and user will be given an error message.
• Edited extensions_controller_spec.rb with small refactoring changes to how groupings are created and with a new test "should not create an extension for a grouping from another course"

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)	x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

• I have updated the project Changelog (this is required for all changes).
• I have verified that the pre-commit.ci checks have passed.
• I have verified that the CI tests have passed.
• I have reviewed the test coverage changes reported by Coveralls.
• I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

[coveralls]

Coverage Report for CI Build 41344729709

Coverage increased (+0.001%) to 91.463%

Details

• Coverage increased (+0.001%) from the base build.
• Patch coverage: 11 of 11 lines across 2 files are fully covered (100%).
• No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	54183
Covered Lines:	50615
Line Coverage:	93.41%
Relevant Branches:	2569
Covered Branches:	1292
Branch Coverage:	50.29%
Branches in Coverage %:	Yes
Coverage Strength:	129.38 hits per line

---

💛 - Coveralls