Skip to content

Add Export PDF with Theme - #80

Open
NikhilMank wants to merge 1 commit into
MarkEdit-app:mainfrom
NikhilMank:add-export-pdf-with-theme
Open

NikhilMank wants to merge 1 commit into
MarkEdit-app:mainfrom
NikhilMank:add-export-pdf-with-theme

Conversation

@NikhilMank

Copy link
Copy Markdown

Exports the document as a PDF that matches the editor's current theme, in light or dark. Requires Markdown View Modes.

@cyanzhong

Copy link
Copy Markdown
Contributor

Thanks for the submission! I found a security issue: cleanHtml() preserves event handlers such as onerror, and the resulting HTML is inserted into the live editor. Exporting crafted Markdown can therefore execute JavaScript with editor API access, potentially reading document content or loading external scripts.

Could you sanitize the HTML before insertion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants