Repository navigation
fix(openmeteo): use daily precipitation probability - #4312
Merged
KristjanESPERANTO merged 1 commit intoOct 23, 2026
Merged
Conversation
…th a typical weather service
Collaborator
|
Looks good, thanks for this! 🙂 Would you like to add a regression test for it? No worries if not. |
Author
|
Sure thing. I'll get it done tomorrow, |
Author
|
Here are the test results for the updated openmeteo.js. I think it checks out. Not sure if you need anything else though - if so let me know. 
|
KristjanESPERANTO
approved these changes
Oct 23, 2026
KristjanESPERANTO
changed the title
Collaborator
These are the existing tests. I was looking for a new test that tests the new behavior, but in that case we can continue without it. Thanks for this improvement! 🙂 |
khassel
pushed a commit
that referenced
this pull request
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to address Issue #4310
Updates openmeteo.js to pull "precipitation_probability_max" from openmeteo and report that as the probability of precipitation. This replaces the previous calculation that returned the % of the day that experiences precipitations.
This changes brings the probability of precipitation result into line with typical weather service behavior.