Repository navigation
build(mcp): install SAGA 1.0.1 from npm, with independently versioned siblings - #15
Merged
Merged
Conversation
… siblings Ansari moves to @saga-a2ui/react-mcp-stack@1.0.1. The stack pins its siblings at their own exact versions: core, components and react at 1.0.0, and mcp at 1.0.2. SAGA now versions its packages independently, so the "one SAGA version" rule is gone. Instead, every SAGA package resolves to exactly the version its dependents pin, and the stack resolves to the direct pin: - check-release.mjs reads the pins from the lockfile's snapshots. - packaging.test.ts checks each sibling's npm version and integrity, the exact pins in the installed tree, and per-package licence notices. A new release test accepts independently versioned siblings. It fails on the previous rule. The Dev, Beta and Production gates now pass, the last two with every package verified against npm. App version 0.17.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s from npm Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yia-mw-agent
approved these changes
Nov 5, 2026
yia-mw-agent
left a comment
Collaborator
There was a problem hiding this comment.
Helmet-Review-Request: #15 (comment)
Reviewed the full merge-base-to-head diff (base develop at 5904323 = merge-base, 8 files) at f34b552, which was also the live head at start and before submitting. No material defects.
What I checked:
- Pins:
package.jsonpins the stack at 1.0.1; the lockfile resolves core/components/react 1.0.0 and mcp 1.0.2, each with registry integrity.apps/mcp/src/version.tsandpackage.jsonagree on 0.17.2. No stale0.17.1or1.0.0-rc.1reference remains outside historical test fixtures. check-release.mjs: the per-package uniqueness check, the owner-to-sibling pin check viasagaPins(parses the real snapshot entries, including peer suffixes) and the stack-vs-direct-pin check are correct. The old one-version rule is replaced rather than weakened: a skewed pin or a second resolved version still fails.- Tests:
packaging.test.tsexpected versions and integrity match the lockfile;release.test.tsadds the independent-siblings case and updates the wrong-pin message match. - Docs: README and walkthrough text match the new pins.
Validation run locally on the exact head:
pnpm install --frozen-lockfile --strict-peer-dependencies --filter ansari-mcp...succeeded.apps/mcp: lint, typecheck andpnpm testall pass (146/146).node scripts/check-release.mjs --target dev|beta|productionall pass, with the registry verified for all five packages on beta and production.- GitHub checks "MCP application" and "gitleaks" are SUCCESS.
Non-blocking: I did not rerun the browser suite or the container smoke test locally; the PR reports them and the CI "MCP application" check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Ansari from SAGA
1.0.0-rc.1to the stable1.0.xrelease on npm.Change
@saga-a2ui/react-mcp-stackis pinned to1.0.1. It pins its siblings at their own exact versions:core,componentsandreactat1.0.0, andmcpat1.0.2.scripts/check-release.mjsreads those pins from the lockfile's snapshots.test/packaging.test.tschecks each package's npm version and integrity (read withnpm view), the exact pins in the installed tree, and per-package licence notices.What 1.0.x brings
majoris now required on views (Ansari already passesmajor: 1), and the stacks no longer exportz(Ansari never used it).413when a Node client talks to the Node listener directly.Verification
pnpm install --frozen-lockfile --strict-peer-dependencies --filter ansari-mcp...succeeds, and the lockfile records the npm integrity of all five packages.pnpm mcp verifypasses: lint, typecheck, 146 tests and 78 browser checks.bash apps/mcp/scripts/verify-container.shpasses; the container servesui://views/answer-card.v1.html.pnpm check:releasepasses fordev,betaandproduction, verifying all five packages against the npm registry.tools/callgets413 Payload Too Largeon both the modern and the older-host path, from the built Node server.🤖 Generated with Claude Code