Repository navigation
Public installs as JSON that any website can read - #40
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Adds
GET /p/{slug}/installs.json: the exact installs of each extension on a public page and their total.{ "installs": 28311, "extensions": [ { "id": 1, "name": "Debug Data Structures Visualizer", "installs": 20163 } ] }Why: the badges only carry a rounded string (
20.2k) and are images, so a portfolio site can't show the numbers in its own style. My site (mccprogrammer.com) will read this endpoint so its project cards stay current without editing them by hand.Details
Access-Control-Allow-Origin: *: the data is public, read-only and served without cookies, so letting any origin read it from the browser exposes nothing new. A simple GET needs no preflight, so no Spring CORS configuration is involved.Tests:
PublicPagesTests.exactInstallsComeAsJsonThatAnyWebsiteMayRead(404 before the address is chosen; header, cache, totals, per-extension numbers, no email). Removing the CORS header makes it fail../mvnw verify: 183 tests pass.