Repository navigation
Check the module structure with Spring Modulith - #37
Merged
Merged
Conversation
Each feature package is a module; ModularityTests fails on a cycle between modules or on a dependency a module's package-info doesn't allow (@ApplicationModule). The structure already had no cycle; the allowed lists are what it uses today, so a new dependency between features is now a reviewed one-line change.
Both sides added a property and a managed dependency in the same places of pom.xml (the pinned Swagger UI from #36, the Spring Modulith BOM here); kept both.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
spring-modulith-apigives the@ApplicationModuleannotation, andspring-modulith-starter-testruns the check, in test scope only.package-info.javanow declares which modules it may use,@ApplicationModule(allowedDependencies = ...). The lists are exactly what the code uses today.storeandauthdepend on no other module.ModularityTests: each top-level package is a module.ApplicationModules.verify()fails on a cycle between modules, or on a dependency that isn't in the module's list.Checks
statsfrompublicpage's list on purpose, and the test failed with: "Module 'publicpage' depends on module 'stats' via PublicPages -> StatsService. Allowed targets: auth."./mvnw verifypasses: 180 tests.