Repository navigation
Close release packaging and configuration gaps - #1
Merged
Merged
Conversation
Co-authored-by: atterdag <6167776+atterdag@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The source archive transform breaks relative symlinks and needs correction before release.
2 open issues
What changed in this PR
Aligns release archives with working-tree package artifacts and supports empty left-button configurations for the KDE theme.
Changes:
- Builds source archives from disk.
- Accepts empty left-button settings and adds regression coverage.
- Clarifies button configuration and uninstall behavior.
| File | Description |
|---|---|
| tests/unit/test_install.sh | Tests empty left-button settings. |
| README.md | Clarifies configuration and backup restoration. |
| packaging/stamp-metadata.py | Handles empty parsed values safely. |
| packaging/make-release.sh | Builds source archives from the working tree. |
| lib/common.sh | Allows defined-but-empty left-button settings. |
Review effort: Balanced
| else | ||
| tar czf "$src_out" "${TARFLAGS[@]}" --exclude='./dist' --transform "s|^\.|quantum-theme-$VER|" . | ||
| fi | ||
| tar czf "$src_out" "${TARFLAGS[@]}" --exclude='./dist' --transform "s|^\.|quantum-theme-$VER|" . |
Comment on lines
+127
to
+129
| assert_contains "generated defaults preserve the empty value" \ | ||
| "$(cat "$QUANTUM_ROOT/variants/light/look-and-feel/QuantumLight/contents/defaults")" \ | ||
| "ButtonsOnLeft=" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUTTONS_LEFT=""intheme.env, then regenerate package defaults.--restore-backuprestores the saved icon-theme setting.BUTTONS_LEFT="" python3 packaging/stamp-metadata.py