Skip to content

Keep the template out of generated solutions - #44

Merged
stphnwlsh merged 2 commits into
mainfrom
fix/ide-auth-option-labels
Nov 5, 2026
Merged

stphnwlsh merged 2 commits into
mainfrom
fix/ide-auth-option-labels

Conversation

@stphnwlsh

@stphnwlsh stphnwlsh commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Keeps the shared template-authoring skill in step with the four web templates. Visual Studio and Rider don't honour isEnabled or isRequired on template options (dotnet/templating#7860), so a toggle's inputs show whatever the toggle says, and Rider sorts text fields alphabetically by label. The skill now says to start an input's label with its feature, so it sits under its checkbox, and to say in its IDE description that it's only used when that box is ticked. The function has no toggles yet.

A second pass over what dotnet new produces tidies a few more things, carried across all five templates:

  • A generated solution no longer gets a stray icon.png in its root, and the shipped AGENTS.md leaves out the line about .template.config.
  • The shared skills now hold with authentication on or off, so they no longer point an agent at AuthenticationSettings or AuthenticationTests.cs in a solution that doesn't have them.
  • The template-authoring rule says a toggle's CLI description leaves out the default, because dotnet new --help prints it, while the IDE description keeps it.
  • Verify Template now checks that nothing of the template leaks into a generated solution (no includeAuth markers, no trace of the template's own name, no icon.png).

Related issues

Follow-up to LeanMeanCleanApps/.github#68

Type of change

  • Bug fix
  • New feature
  • Breaking change (the generated solution or template parameters change in a way existing users will notice)
  • Refactoring or clean-up
  • Documentation
  • Build, pipeline or dependency update

Shared layers

  • This only touches the Presentation layer of this template.
  • This touches the Application or Infrastructure layers, tests, pipeline or repository setup, so it needs to be carried across all five templates.

Checklist

  • dotnet build and dotnet test pass locally with no warnings.
  • I added or updated tests, and line coverage stays at or above 95%.
  • I updated the README or docs where behaviour changed.
  • If this changes how we do something, I updated the matching skill in .agents/skills.
  • I checked the template still installs and creates a working solution (see CONTRIBUTING.md).

Generated by Claude Code

@github-actions github-actions Bot added the bug Something isn't working label Nov 5, 2026
@stphnwlsh stphnwlsh self-assigned this Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Build Pipeline

✅ Ready to merge. Every stage passed.

Stage Result Details
Build 🟢 Passed Version 2026.11.05.158-pr-44 · Template package 203 KB
Test 🟢 Passed 180 passed · 0 failed · 0 skipped · Template installs, builds and passes its tests
Coverage 🟢 Passed 100% (650 of 650 lines) · Needs 95%
Static Analysis 🟢 Passed No open CodeQL alerts
Dependency Review 🟢 Passed 0 vulnerable packages · 0 licence problems
Container Scan 🟢 Passed Image starts and answers · 3 open Trivy alerts, none blocking: 1 medium, 1 low, 1 note · 1 ignored in .trivyignore

Commit 4f84508 · Full run

A generated solution no longer gets icon.png in its root, and the shipped
AGENTS.md leaves out the line about .template.config. The skills now hold
with authentication on or off, so an agent working in a solution created
without --include-auth isn't told to add RequireAuthorization or look for
AuthenticationSettings. The CLI descriptions drop "Default: off." because
dotnet new --help prints the default; the IDE descriptions keep it.

Verify Template now checks that nothing of the template leaks into a
generated solution and that --include-auth without --authority is refused.
@github-actions github-actions Bot added the build label Nov 5, 2026
@stphnwlsh stphnwlsh changed the title Note that the IDEs show a toggle's inputs whatever the toggle says Keep the template out of generated solutions Nov 5, 2026
@stphnwlsh
stphnwlsh merged commit 45c440e into main Nov 5, 2026
13 checks passed
@stphnwlsh
stphnwlsh deleted the fix/ide-auth-option-labels branch November 5, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant