Skip to content

Keep the template out of generated solutions and group the token options in the IDEs - #55

Merged
stphnwlsh merged 2 commits into
mainfrom
fix/ide-auth-option-labels
Nov 5, 2026
Merged

stphnwlsh merged 2 commits into
mainfrom
fix/ide-auth-option-labels

Conversation

@stphnwlsh

@stphnwlsh stphnwlsh commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Visual Studio and Rider don't honour isEnabled or isRequired on template options (dotnet/templating#7860), so the token authority and audience show in the new project dialog even with Include authentication unticked. Rider also lists checkboxes first and then text fields in alphabetical order by label, which put the two token fields under Author name, away from the checkbox they belong to.

They're now "Authentication authority" and "Authentication audience (optional)", so they sort straight under Include authentication, and their IDE descriptions say they're only used when it's ticked. dotnet new on the command line is unchanged and still enables and requires them only with --include-auth. The template-authoring skill says how to label a toggle's inputs.

A second pass over what dotnet new produces tidies a few more things:

  • A generated solution no longer gets a stray icon.png in its root, and the shipped AGENTS.md leaves out the line about .template.config.
  • The skills now hold with authentication on or off, so an agent in a solution created without --include-auth isn't told to add RequireAuthorization() or to look for AuthenticationSettings.
  • The CLI description of --include-auth drops "Default: off." because dotnet new --help prints the default under every option; the IDE description keeps it, since the dialogs don't.
  • Verify Template now checks that nothing of the template leaks into a generated solution (no includeAuth markers, no trace of the template's own name, no icon.png), and that --include-auth without --authority is refused with exit code 102.

Related issues

Follow-up to LeanMeanCleanApps/.github#68

Type of change

  • Bug fix
  • New feature
  • Breaking change (the generated solution or template parameters change in a way existing users will notice)
  • Refactoring or clean-up
  • Documentation
  • Build, pipeline or dependency update

Shared layers

  • This only touches the Presentation layer of this template.
  • This touches the Application or Infrastructure layers, tests, pipeline or repository setup, so it needs to be carried across all five templates.

Checklist

  • dotnet build and dotnet test pass locally with no warnings.
  • I added or updated tests, and line coverage stays at or above 95%.
  • I updated the README or docs where behaviour changed.
  • If this changes how we do something, I updated the matching skill in .agents/skills.
  • I checked the template still installs and creates a working solution (see CONTRIBUTING.md).

Generated by Claude Code

@github-actions github-actions Bot added the bug Something isn't working label Nov 5, 2026
@stphnwlsh stphnwlsh self-assigned this Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Build Pipeline

✅ Ready to merge. Every stage passed.

Stage Result Details
Build 🟢 Passed Version 2026.11.05.195-pr-55 · Template package 226 KB
Test 🟢 Passed 214 passed · 0 failed · 0 skipped · Template installs, builds and passes its tests
Coverage 🟢 Passed 100% (619 of 619 lines) · Needs 95%
Static Analysis 🟢 Passed No open CodeQL alerts
Dependency Review 🟢 Passed 0 vulnerable packages · 0 licence problems
Container Scan 🟢 Passed Image starts and answers · No open Trivy alerts

Commit ce894a8 · Full run

A generated solution no longer gets icon.png in its root, and the shipped
AGENTS.md leaves out the line about .template.config. The skills now hold
with authentication on or off, so an agent working in a solution created
without --include-auth isn't told to add RequireAuthorization or look for
AuthenticationSettings. The CLI descriptions drop "Default: off." because
dotnet new --help prints the default; the IDE descriptions keep it.

Verify Template now checks that nothing of the template leaks into a
generated solution and that --include-auth without --authority is refused.
@github-actions github-actions Bot added the build label Nov 5, 2026
@stphnwlsh stphnwlsh changed the title Label the token options so they sit with Include authentication in the IDEs Keep the template out of generated solutions and group the token options in the IDEs Nov 5, 2026
@stphnwlsh
stphnwlsh merged commit f87d7a3 into main Nov 5, 2026
13 checks passed
@stphnwlsh
stphnwlsh deleted the fix/ide-auth-option-labels branch November 5, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant