Repository navigation
Keep the template out of generated solutions and group the token options in the IDEs - #55
Merged
Merged
Conversation
Contributor
Build Pipeline✅ Ready to merge. Every stage passed.
Commit |
A generated solution no longer gets icon.png in its root, and the shipped AGENTS.md leaves out the line about .template.config. The skills now hold with authentication on or off, so an agent working in a solution created without --include-auth isn't told to add RequireAuthorization or look for AuthenticationSettings. The CLI descriptions drop "Default: off." because dotnet new --help prints the default; the IDE descriptions keep it. Verify Template now checks that nothing of the template leaks into a generated solution and that --include-auth without --authority is refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual Studio and Rider don't honour
isEnabledorisRequiredon template options (dotnet/templating#7860), so the token authority and audience show in the new project dialog even with Include authentication unticked. Rider also lists checkboxes first and then text fields in alphabetical order by label, which put the two token fields under Author name, away from the checkbox they belong to.They're now "Authentication authority" and "Authentication audience (optional)", so they sort straight under Include authentication, and their IDE descriptions say they're only used when it's ticked.
dotnet newon the command line is unchanged and still enables and requires them only with--include-auth. Thetemplate-authoringskill says how to label a toggle's inputs.A second pass over what
dotnet newproduces tidies a few more things:icon.pngin its root, and the shippedAGENTS.mdleaves out the line about.template.config.--include-authisn't told to addRequireAuthorization()or to look forAuthenticationSettings.--include-authdrops "Default: off." becausedotnet new --helpprints the default under every option; the IDE description keeps it, since the dialogs don't.includeAuthmarkers, no trace of the template's own name, noicon.png), and that--include-authwithout--authorityis refused with exit code 102.Related issues
Follow-up to LeanMeanCleanApps/.github#68
Type of change
Shared layers
Checklist
dotnet buildanddotnet testpass locally with no warnings..agents/skills.Generated by Claude Code