Repository navigation
feat(s3): db-core 0.237, credentials from an ECS task or EC2 instance role (#228) - #230
Merged
Merged
Conversation
… role (#228) db-core 0.237 (t-rust-db/db-core#1042) adds the container credentials endpoint and IMDSv2 to the credential chain, and fetches a role's credentials again before they expire. FRANK's call is unchanged (S3Config::from_uri(location, Credentials::from_chain()?)), so FRANK on EC2 or ECS signs with its role and no access key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S3Config::from_uri(location, Credentials::from_chain()?)inobjects.rs). WithFRANK_STOREon EC2 or ECS it now signs with the role, with no access key in its environment.Changes
Changed
Cargo.toml/Cargo.lock: db-corev0.237.0.--storehelp, README "Storage: filesystem or S3" and ADR-019: the credential chain now includes the ECS task role and the EC2 instance role.Changelog
FRANK_STORE, FRANK signs with an ECS task role or the EC2 instance role (IMDSv2) when no keys are in the environment or the shared credentials file, and fetches the role's credentials again before they expire (db-core 0.237, Verify s3 mode against AWS S3 over HTTPS (TLS adapter, lease, IAM role) #228).Testing
cargo clippy --workspace --all-targets --features frank/tls -D warningscargo test --workspace --features frank/tlsRelated Issues
Related to #228 (the live check follows on the test VM)
🤖 Generated with Claude Code