Skip to content

feat(make): s3-column over https by default, TLS=0 and URL= switch it (#220) - #227

Merged
iheitlager merged 2 commits into
mainfrom
feat/#220-s3-column-tls
Nov 8, 2026
Merged

iheitlager merged 2 commits into
mainfrom
feat/#220-s3-column-tls

Conversation

@iheitlager

Copy link
Copy Markdown
Member

Summary

  • make s3-column reads the sightings over HTTPS by default (https://frank.local:9443, Caddy's local CA from target/frank-local-ca.crt), now that feat: HTTPS for the local Garage S3 API through Caddy (make up-s3) #224 serves Garage's S3 API there.
  • TLS=0 switches to plain http (127.0.0.1:3900); URL=s3://bucket/prefix?endpoint=…&region=… reads any other location, e.g. AWS or another Garage.
  • It prints the location it reads first, in colour on a terminal (https green, http yellow, NO_COLOR respected), on stderr so query output stays clean.

Changes

Changed

  • scripts/read-garage-column.sh: TLS default, TLS=0, URL=, credentials from s3/frank.env unless AWS_ACCESS_KEY_ID is set, AWS_CA_BUNDLE honoured with URL=, minimum column-rs 0.46.0 for https and 0.45.0 for http, location line.
  • Makefile: s3-column passes TLS and URL; help text updated.
  • README.md: S3 paragraph updated.

Changelog

  • make s3-column reads over HTTPS by default; TLS=0 reads over http and URL=s3://… reads any location; it prints the location first.

Testing

  • Ran against make up-s3: default (https), TLS=0 and URL= each returned the same count(*) (254) from sightings.
  • Missing CA file fails with a hint (make trust, or TLS=0).
  • Coloured output not seen on a real terminal (no pty here); plain output checked.
  • Needs column-rs 0.46+ built with --features s3-tls for https.

Related Issues

Related to #220 (audit on S3, FRANK's own TLS adapter and deploy/aws/ remain).


🤖 Generated with Claude Code

iheitlager and others added 2 commits November 8, 2026 20:47
…tch it, says where first (#220)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@iheitlager
iheitlager merged commit 81832c0 into main Nov 8, 2026
2 checks passed
@iheitlager
iheitlager deleted the feat/#220-s3-column-tls branch November 8, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant