Repository navigation
feat(make): s3-column over https by default, TLS=0 and URL= switch it (#220) - #227
Merged
Merged
Conversation
…tch it, says where first (#220) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make s3-columnreads the sightings over HTTPS by default (https://frank.local:9443, Caddy's local CA fromtarget/frank-local-ca.crt), now that feat: HTTPS for the local Garage S3 API through Caddy (make up-s3) #224 serves Garage's S3 API there.TLS=0switches to plain http (127.0.0.1:3900);URL=s3://bucket/prefix?endpoint=…®ion=…reads any other location, e.g. AWS or another Garage.NO_COLORrespected), on stderr so query output stays clean.Changes
Changed
scripts/read-garage-column.sh: TLS default,TLS=0,URL=, credentials froms3/frank.envunlessAWS_ACCESS_KEY_IDis set,AWS_CA_BUNDLEhonoured withURL=, minimum column-rs 0.46.0 for https and 0.45.0 for http, location line.Makefile:s3-columnpassesTLSandURL; help text updated.README.md: S3 paragraph updated.Changelog
make s3-columnreads over HTTPS by default;TLS=0reads over http andURL=s3://…reads any location; it prints the location first.Testing
make up-s3: default (https),TLS=0andURL=each returned the samecount(*)(254) fromsightings.make trust, orTLS=0).--features s3-tlsfor https.Related Issues
Related to #220 (audit on S3, FRANK's own TLS adapter and
deploy/aws/remain).🤖 Generated with Claude Code