Skip to content

Merge a pull request from its page, and open it from the row's glyph - #36

Merged
KieranP merged 1 commit into
mainfrom
pr-merge
Oct 29, 2026
Merged

KieranP merged 1 commit into
mainfrom
pr-merge

Conversation

@KieranP

@KieranP KieranP commented Oct 29, 2026

Copy link
Copy Markdown
Owner

The PR page already says whether GitHub would merge a pull request, so merging belongs beside that verdict. Merge turns the page into a form opened on GitHub's own default method and its own subject and message for each, read in one gh api graphql call since no gh pr command prints them. The merge goes through gh pr merge, held to the head whose checks the page showed, so a push since fails it rather than landing unseen commits.

  • Offer Merge When Ready where only required checks still run, and Cancel Auto-Merge where auto-merge is on; nothing for a draft, a conflict or changes requested
  • Say in the form when the repository has auto-merge off or the account may not write to it, which the banner cannot know before the read
  • Click the row's PR or CI glyph to open that page of the panel, in place of a popover that repeated both pages

What this does

What I ran

  • make format
  • make lint
  • make test
  • make build

What I could not verify:

Docs

  • A design note under Docs/design/ if this changes a decision, or the
    reason it does not need one.
  • An issue if this leaves a gap rather than closing it, labelled
    unconfirmed if nobody has watched it go either way.

@KieranP KieranP self-assigned this Oct 29, 2026
@KieranP
KieranP force-pushed the pr-merge branch 2 times, most recently from fab3605 to 968ee9c Compare October 29, 2026 08:07
The pull request page already says whether GitHub would merge, so
merging sits on its readiness banner: Merge where the card reads ready,
Merge When Ready where only required checks running or GitHub working
out conflicts hold it back, and Cancel Auto-Merge where auto-merge is
on. Merge turns the page into a form opened on GitHub's own default
method and its own subject and message for each, read in one gh api
graphql call, as no gh pr command prints them.

- Merge through gh pr merge, named by the pull request's page and held
  to the head whose checks the page showed, so a push since fails it
- Weigh a form where the list or the checks change, dropping it on a
  push, a merge or close elsewhere, a lasting blocker or the host off
- Say in the form when the repository has auto-merge off or the account
  may not write to it, and say a failed list read on the page
- Click the row's PR or CI glyph to open that page of the panel, in
  place of a popover that repeated both pages

Closes #32

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@KieranP
KieranP merged commit a531ba6 into main Oct 29, 2026
2 checks passed
@KieranP
KieranP deleted the pr-merge branch October 29, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant