Repository navigation
test(v2): 0090 place-order latency experiment and sandbox order cleanup - #31
Draft
spbsoluble wants to merge 3 commits into
Draft
spbsoluble wants to merge 3 commits into
spbsoluble wants to merge 3 commits into
Conversation
Track, then revoke (issued) or cancel (pending) only the order ids listed in CERTINEXT_V2_CLEANUP_ORDERS, then re-track to verify. Optional CERTINEXT_V2_CLEANUP_DRYRUN=1 reports details without acting; CERTINEXT_V2_CLEANUP_FORCE_CANCEL=1 (single id) makes one raw cancel attempt and re-reads the order report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only change for issue 0090 (enroll/sync race: duplicate key on the gateway's enroll save). Stacked on #30. No product code changes.
What this adds
V2PlaceOrderLatencyExperimentTests(opt-in,CERTINEXT_V2_LATENCY_EXPERIMENT=1): runs the plugin's real V2Enrollthrough a timing proxy overICERTInextClient, with a parallel/reports/orderspoller and a Track Order poller, to measure how long the CA call stays open and when a concurrent sync can see the order.V2OrderCleanupTests(opt-in,CERTINEXT_V2_CLEANUP_ORDERS=<ids>): revokes or cancels explicitly listed sandbox orders only (digits-only IDs, max 25, optional dry run, no pattern matching, no sync).experiment-results/(5 CSVs + a summary) from 13 sandbox orders.Findings (sandbox, 13 orders; suggestive for production, not proof)
PUT /csr: 17-23 s (median 20 s) while the order is alreadyissued. TotalEnroll25-30 s./reports/orders~1.5 s after create, as "Approved by System" with no certificate, for ~20-25 s beforeEnrollreturns the CARequestID. A sync pass in that window inserts a body-less row and the enrollment's save then fails.UQ_Certificates_CertificateAuthorityID_CARequestID. A fifth enrollment failed separately on a CERTInext 500 on place-order that still created an order.Test plan
Draft until reviewed.