Repository navigation
Account for nested process groups in the RSS guard - #72
Conversation
Signed-off-by: kikashy <kikashy@hotmail.com>
Signed-off-by: kikashy <kikashy@hotmail.com>
|
Independent review of judgment-pack-devkit PR #72, addressing #65. Head: Reviewer: OpenAI, Findings: none. Reviewed the issue and comment, applicable Validation reused the coordinator-verified exact-head CI run
Limits: no broad suite repeated and no consumer Go race suite executed. The guard remains sampled and cooperative; descendants creating a new session escape measurement and cleanup, as explicitly documented. HEAD and tracked files remained unchanged. No Git writes, publication, or merge performed. Disposition:
|
|
🎉 Thank you for your contribution to Judgment Pack! If you’d like another task, choose a path that interests you: |
Closes #65. Milestone:
v0.14.0. One issue per PR; stack order #70 → #65 → #69 → #71.Summary
GNU timeout can place descendants in another process group, outside the former RSS accounting. The guard now samples all non-zombie processes in its launched session and keeps monitoring after the leader exits. Limit and interruption cleanup targets the observed groups and verifies that no runnable session members remain.
Public surface
RSS accounting and cleanup scope, session wording in diagnostics, positive integer limit validation, and documented bounded Go race invocation. Normal Go wrapper defaults are unchanged.
Acceptance mapping
Eight focused tests pass; shellcheck passes. Descendants that create a new session are neither measured nor cleaned up by this cooperative guard. Sampled RSS is not an instantaneous memory reservation. The tests verify wrapper behavior with bounded process probes; they do not claim a consumer Go race suite executed.
Checks
PR head:
4a99e4e0ed3275913319d41ec95df99badbe4f7f.The full checklist ran once on the clean integrated batch head
a8ec74e2b70608d350f5cca740ec777fa41fdb7d, usingscripts/dev/check.sh --allunder the configured shared lock. No uncommitted diff. This batch result does not replace exact-head CI for the individual PRs. Only the machine-local interpreter path is omitted from this runner summary:Review and release status
Authored, executed, independently reviewed and merged into
mainasc7c88298d176fdb258d8b95e664c60e831c733dc. Exact-head lint, tests and DCO passed before merge. Review record reports no findings; it identifies the same-vendor reviewer and actual model. The merged tree exactly matches the reviewed candidate. Published in v0.14.0; release verification record. Consumer rollout remains a separate gate.Sign-off
Commits carry the repository-required sign-off.