Repository navigation
Conversation
c-dilks
requested review from
baltzell,
raffaelladevita and
zieglerv
as code owners
October 24, 2026 01:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jnp-hipoactually packs a lot of stuff, including things found in other JARs. To isolate what is actually being used, I first disabled dependency analysis checks, removedjnp-hipoform the POMs, and checked compiler errors, which revealed that only the followingjnp-hipoclasses are actually used incoatjava:org.jlab.jnp.matrix.Matrix5x5_4x4org.jlab.jnp.matrix.Matrix5x5org.jlab.jnp.matrix.MatrixThe only modules that import these directly are:
common-tools/clas-trackingreconstruction/dcreconstruction/fmtreconstruction/muAll of these depend on
common-tools/clas-physics, and no other Java code beyondcoatjavauses these classes, so I've copied those 3org.jlab.jnp.matrixclasses into there, sourced from https://code.jlab.org/hallb/clas12/coatjava/jnp/-/tree/master/jnp-utils/src/main/java/org/jlab/jnp/matrix?ref_type=headsThis gives us a successful build, but re-enabling dependency analysis caused further errors, revealing additional transitive dependencies in
jnp-hipothat we're using. They are all 'used undeclared dependency' cases, so they are resolved by simply including the actual dependency being used, directly:common-tools/clas-detector, used undeclared dependency found:org.jlab.coda:jevio; turns out thatjnp-hipoincludesjevioin its JAR!reconstruction/eb, used undeclared dependency found:org.jlab.jnp:jnp-hipo4; we just need theJsonObjectclass here, which is found in bothjnp-hipo4andjnp-hipo, so depend onjnp-hipo4rather thanjnp-hipo