Repository navigation
reduce Hit[][][] memory allocations with a pool - #1515
Merged
Merged
Conversation
baltzell
marked this pull request as ready for review
October 14, 2026 21:13
baltzell
changed the title
tongtongcao
previously approved these changes
Oct 15, 2026
tongtongcao
left a comment
tongtongcao
left a comment
Collaborator
There was a problem hiding this comment.
Results are identical before and after updates.
Collaborator
Author
Merge conflict with #1518 means this one needs re-approval ... |
tongtongcao
approved these changes
Oct 19, 2026
tongtongcao
left a comment
tongtongcao
left a comment
Collaborator
There was a problem hiding this comment.
Results are still identical before and after updates
baltzell
enabled auto-merge (squash)
October 19, 2026 15:24
baltzell
added a commit
that referenced
this pull request
Oct 19, 2026
* reduce memory allocations with a pool * cleanup * fix merge conflict mistake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a few-% of our memory allocations, according to asprof. And looks like about 50-million, 32-bit allocations per call (2 per event), based on tallying up the array dimensions and
Hitsize.The 64-size pool is good enough unless this were to start getting used by multiple engines.