Repository navigation
Test for jumps out of exception handler; update DLR - #2121
Merged
Merged
Conversation
slozier
approved these changes
Oct 28, 2026
slozier
left a comment
slozier
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Will merge once tests pass. I think I also had some tweaks to the StdLib which can now be reverted but I can take care of those.
slozier
reviewed
Oct 28, 2026
|
|
||
| with self.assertRaises(System.FormatException) as cm: | ||
| call() | ||
| self.assertIn('Int32.Parse', cm.exception.StackTrace) |
Contributor
There was a problem hiding this comment.
Interestingly this isn't in the stack on .NET Framework.
BCSharp
force-pushed
the
except-continue
branch
from
October 28, 2026 19:49
3542d7c to
868fb83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings in IronLanguages/dlr#371, resolves #1182.