Repository navigation
Extend CodeQL to the actions language, settle on security-extended, and document the alert dismissal policy (#341) - #366
Open
Kshot3000 wants to merge 2 commits into
Conversation
…t dismissal policy (IntersectMBO#341) The workflow merged in IntersectMBO#335 covers the website sources only. The workflow files under .github/workflows/ are the highest-privilege code in this repo (deploy.yml holds pages: write and id-token: write) and nothing analysed them. - Add an actions matrix entry (build-mode: none) alongside javascript-typescript, so workflow YAML gets the same SAST coverage: the actions query pack covers code injection in workflows, unpinned or third-party actions and cleartext credentials, among others. - TRIAGE.md: the Security scanning section now records that workflows are covered, and a new subsection states the code scanning dismissal policy — only a maintainer may dismiss, and only with one of the three GitHub reason codes (false positive / won't fix / used in tests), each with its bar for what the dismissal comment must show. The query-suite comparison (default vs security-extended) numbers are recorded on IntersectMBO#341; this change keeps the suite that comparison supports.
…ctMBO#341) Comparison run on a throwaway fork branch, both suites against this tree (numbers also recorded on IntersectMBO#341): - default suite: javascript-typescript 87 rules, actions 17 rules — 0 results - security-extended suite: javascript-typescript 103 rules, actions 23 rules — 0 results The wider suite surfaces nothing extra on the current code, so the noise risk does not materialise and the extra 22 rules are free coverage. Making it the default here rather than leaving the suite un-chosen.
Kshot3000
requested review from
IanoNjuguna,
Ranchhand87 and
danbaruka
as code owners
October 18, 2026 11:49
3 tasks
Contributor
|
hey, gonna review this before merging |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Follow-up to #298 / #335, closing out #341 in one change:
1. The
actionslanguage is analysed. One matrix entry (build-mode: none) alongsidejavascript-typescript. The Actions extractor reads the workflow YAML directly, and the run on my fork analyses this repo's workflows cleanly with no extra configuration: 17 rules (default suite), 0 results. These are the highest-privilege files in the repo —deploy.ymlholdspages: writeandid-token: write— and until now nothing scanned them.2. The query suite is settled:
security-extended. Comparison run on a throwaway fork branch, both suites against this tree:The wider suite surfaces nothing extra on the current code, so the noise risk #341 flags does not materialise — the extra 22 rules are free coverage, and the suite is now a decision instead of a default. (The numbers are also recorded on #341 itself.)
3. TRIAGE.md states the dismissal policy. Only a maintainer may dismiss a code scanning alert, and only with one of the three GitHub reason codes —
false positive,won't fix,used in tests— each with what the dismissal comment must show; dismissing for convenience or without an explanation is explicitly not acceptable, and dismissals are revisited in the monthly review. The Security scanning section also now records that workflows are covered.Verification
queries:line, and comments..github/workflows/codeql.ymlandTRIAGE.md.Built and maintained by me, an independent Cardano community builder — not affiliated with the Cardano Foundation, IOG or Intersect.
@Kshot9000 (https://x.com/kshot9000) · ADA: addr1q8hnl6vl5a6k3rw3n5g3jtte696zcl76kfatzv7gpswa9r0dj7fma6klq55y4ffm7tf0em09udnyhuk4ah92pl5x9jpqjae44v
cc @cardano-foundation @IntersectMBO